Bug 193545 - www/mod_log_mysql [maintainer] add support for recent apache.mk changes
Summary: www/mod_log_mysql [maintainer] add support for recent apache.mk changes
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-10 22:21 UTC by Chris Hutchinson
Modified: 2014-11-02 22:50 UTC (History)
2 users (show)

See Also:

Attachments
www/mod_log_mysql diff accomodates recent changes to apache.mk (611 bytes, patch)
2014-09-10 22:21 UTC, Chris Hutchinson 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2014-09-10 22:21:00 UTC 
Created attachment 147202 [details]
www/mod_log_mysql diff accomodates recent changes to apache.mk

www/mod_log_mysql

adds apache22+ support
bumps PORTREVISION

nothing more, nothing less. :)

See 2014-09-10.diff, attached.

Thanks.

--Chris
Comment 1 John Marino freebsd_committer freebsd_triage 2014-10-08 18:18:04 UTC 
poudriere log, please.
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-10-31 19:09:49 UTC 
A commit references this bug:

Author: marino
Date: Fri Oct 31 19:09:46 UTC 2014
New revision: 371882
URL: https://svnweb.freebsd.org/changeset/ports/371882

Log:
  www/mod_log_mysql: According to maintainer, it's okay for Apache 24

  PR:		193545

Changes:
  head/www/mod_log_mysql/Makefile
Comment 3 John Marino freebsd_committer freebsd_triage 2014-10-31 19:11:23 UTC 
It didn't need the revbump.

Hopefully this fix is legit.
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2014-11-01 09:53:13 UTC 
I add to revert it as it doesn't work
Comment 5 John Marino freebsd_committer freebsd_triage 2014-11-01 10:32:20 UTC 
(In reply to Antoine Brodin from comment #4)
> I add to revert it as it doesn't work

s/add/ask/ ?

Why am I not surprised it doesn't work..
Comment 6 John Marino freebsd_committer freebsd_triage 2014-11-01 10:38:52 UTC 
Chris,
The change was reverted by antoine@.  As the maintainer, you're expected to verify that it works as well as builds.  The change I committed on your behalf broke with www/mod_log_config-st
Comment 7 Chris Hutchinson 2014-11-02 20:20:37 UTC 
(In reply to John Marino from comment #6)
> Chris,
> The change was reverted by antoine@.  As the maintainer, you're expected to
> verify that it works as well as builds.  The change I committed on your
> behalf broke with www/mod_log_config-st

Sorry. I'm having difficulty following this thread.
My build box crapped out. So I'll just revert all
the 2.2 ==> 2.4 changes (see; repost original(s))
and revisit the 2.2 ==> 2.4 when I have a suitable
development environment again.

--Chris

P.S. I have a submission from another person who
added build/QA reports that seems to make this
2.2 && 2.4 capable. But didn't submit them, as I
am not (yet) able to test them locally.
Comment 8 John Marino freebsd_committer freebsd_triage 2014-11-02 20:23:51 UTC 
summary:

1) I changed the port to allow building on Apache 2.4
2) My commit was reverted less than 12 hours later because it effectively can't be used on apache 2.4

I don't know what you mean by "revert all the changes"

There was a single line that changed and it was reverted already.
Comment 9 Chris Hutchinson 2014-11-02 22:50:31 UTC 
(In reply to John Marino from comment #8)
> summary:
> 
> 1) I changed the port to allow building on Apache 2.4
> 2) My commit was reverted less than 12 hours later because it effectively
> can't be used on apache 2.4
> 
> I don't know what you mean by "revert all the changes"
> 
> There was a single line that changed and it was reverted already.

Thanks.

--Chris