Bug 193580 - [PATCH] games/2048: update to latest master
Summary: [PATCH] games/2048: update to latest master
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-12 09:22 UTC by Dmitry Marakasov
Modified: 2014-09-15 15:54 UTC (History)
1 user (show)

See Also:

Attachments
2048-0.0.0.2014091201.patch (1.52 KB, patch)
2014-09-12 09:22 UTC, Dmitry Marakasov 		no flags Details | Diff
Patch (2.15 KB, patch)
2014-09-12 23:24 UTC, Dmitry Marakasov 		no flags Details | Diff
Patch (2.21 KB, patch)
2014-09-12 23:26 UTC, Dmitry Marakasov 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2014-09-12 09:22:47 UTC 
Created attachment 147240 [details]
2048-0.0.0.2014091201.patch

- Update to latest master, to which my Makefile changes were accepted, so patching in the port is no nonger needed

Port maintainer (swills@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 1.02 (mode: update, diff: SVN)
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2014-09-12 15:45:07 UTC 
Although wait a bit. The game saves its highscore file in the current directory, this is unacceptable. I'll fix that.
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2014-09-12 23:24:03 UTC 
Created attachment 147258 [details]
Patch

Updated patch:

- update to latest master, with fixed Makefile and highscore file handling
- remove MASTER_SITES, it's handled by USE_GITHUB
- fix LICENSE_FILE (misspelled as LICENSE_FILES, needs full path ${WRKSRC})
- don't install LICENSE (already installed by license framework)
- simplify plist handling by using PORTDOCS=
- optionize DOCS installation
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2014-09-12 23:26:48 UTC 
Created attachment 147259 [details]
Patch

Updated the patch again:

- use INSTALL_DATA, not INSTALL_MAN for documentation. The latter may do some unneeded things like compression or some conversion.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-09-15 15:54:24 UTC 
A commit references this bug:

Author: amdmi3
Date: Mon Sep 15 15:53:58 UTC 2014
New revision: 368272
URL: http://svnweb.freebsd.org/changeset/ports/368272

Log:
  - Update to latest master, which fixes highscore and color handling and doesn't need makefile patching any more
  - Remove MASTER_SITES, this is handled by USE_GITHUB
  - Fix LICENSE_FILE
  - Improve installation

  PR:		193580
  Submitted by:	amdmi3
  Approved by:	swills (maintainer, via irc)

Changes:
  head/games/2048/Makefile
  head/games/2048/distinfo
  head/games/2048/files/