Bug 193632 - devel/json-c: Remove unconditional -Werror flag to fix build on modern gcc
Summary: devel/json-c: Remove unconditional -Werror flag to fix build on modern gcc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-14 09:48 UTC by John Marino
Modified: 2014-09-14 15:55 UTC (History)
0 users

See Also:
marino: maintainer-feedback? (sunpoet)


Attachments
Makefile patch to remove -Werror flag in $WRKSRC/Makefile.in (268 bytes, patch)
2014-09-14 09:48 UTC, John Marino
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer freebsd_triage 2014-09-14 09:48:59 UTC
Created attachment 147304 [details]
Makefile patch to remove -Werror flag in $WRKSRC/Makefile.in

The json-c makefile passes the -Werror flag during the build and it can't be turned off via the configure script.  The Werror flag shouldn't be set in ports.

Here's the failure on gcc47:

json_tokener.c: In function 'json_tokener_parse_ex':
json_tokener.c:355:6: error: variable 'size' set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors


The fix is attached.

I can commit it if you approve.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-14 09:48:59 UTC
Auto-assigned to maintainer sunpoet@FreeBSD.org
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-09-14 15:55:13 UTC
A commit references this bug:

Author: sunpoet
Date: Sun Sep 14 15:54:17 UTC 2014
New revision: 368196
URL: http://svnweb.freebsd.org/changeset/ports/368196

Log:
  - Remove -Werror

  PR:		ports/193632
  Submitted by:	marino

Changes:
  head/devel/json-c/Makefile