Created attachment 147465 [details] Squidguard 1.4 helper protocol patch. Using squidguard with the current squid port, version 3.4.x, a warning 'UPGRADE WARNING: URL rewriter reponded with garbage' is generated by squid in cache.log, every time a url is blocked or redirected. This is caused by squidguard using the old squid 2.7 redirector protocol. A patch for squidguard 1.4 and 1.5 beta is available at the squidcache site. See squid bug report 3978, http://bugs.squid-cache.org/show_bug.cgi?id=3978, for more information. Since squid 3.4.x is the only supported version by FreeBSD, this patch should be applied to the www/squidguard port. The proposed patch is attached.
Auto-assigned to maintainer madpilot@FreeBSD.org
Thanks for this report and patch. You are definitely right. The patch lookd good, I'm going to perform some testing and commit it soon.
Committed! Thanks.
A commit references this bug: Author: madpilot Date: Fri Sep 19 21:33:28 UTC 2014 New revision: 368602 URL: http://svnweb.freebsd.org/changeset/ports/368602 Log: - Import patch from upstream to allow squidguard to work correctly with squid 3.4 [1] - Put back the option to choose on which squid version to depend, which also controls if the above patch is applied, to allow using squid33 until it expires - While here, take advantage of option helpers to simplify Makefile a little - Canonicalize patch filenames PR: 193771 [1] Submitted by: adrik@salesmanager.nl Changes: head/www/squidguard/Makefile head/www/squidguard/files/extrapatch-squid34 head/www/squidguard/files/patch-sample_sample.conf.in head/www/squidguard/files/patch-samples__sample.conf.in head/www/squidguard/files/patch-src__main.c head/www/squidguard/files/patch-src__sgDb.c head/www/squidguard/files/patch-src_main.c head/www/squidguard/files/patch-src_sgDB.c