Bug 193785 - [patch]: devel/p5-PatchReader: fix new file detection in SVN patches
Summary: [patch]: devel/p5-PatchReader: fix new file detection in SVN patches
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Marcus von Appen
URL: https://rt.cpan.org/Public/Bug/Displa...
Keywords: patch
Depends on:
Blocks: 190724
  Show dependency tree / graph
 
Reported: 2014-09-20 07:27 UTC by Marcus von Appen
Modified: 2014-09-21 17:00 UTC (History)
2 users (show)

See Also:
toni.viemero: maintainer-feedback+

Attachments
Parser patch (1.97 KB, patch)
2014-09-20 07:27 UTC, Marcus von Appen 		no flags Details | Diff
Console test script (355 bytes, text/plain)
2014-09-20 07:28 UTC, Marcus von Appen 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus von Appen freebsd_committer freebsd_triage 2014-09-20 07:27:43 UTC 
Created attachment 147496 [details]
Parser patch

PatchReader eats up new file additions in the Raw parser due to several wrong regexp matchers. 

The attached patch fixes fixes

* new file start marks 
* new file end marks
* new file filename detection

The misbehaviour can be seen in the parser output for the attachments mentioned in bug 190724.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-20 07:27:43 UTC 
Maintainer CC'd
Comment 2 Marcus von Appen freebsd_committer freebsd_triage 2014-09-20 07:28:51 UTC 
Created attachment 147497 [details]
Console test script

Simple test script for the parser
Comment 3 Marcus von Appen freebsd_committer freebsd_triage 2014-09-20 07:32:51 UTC 
Added reports from other systems for this issue.
Comment 4 Toni Viemerö 2014-09-20 09:25:46 UTC 
Looks fine to me. Apparently Eclipse have tried and tested properly.
Comment 5 Marcus von Appen freebsd_committer freebsd_triage 2014-09-21 17:00:35 UTC 
Committed, thanks for the quick feedback.