Bug 193823 - sysutils/volman: new maintainer - new download location
Summary: sysutils/volman: new maintainer - new download location
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-22 02:17 UTC by Uffe Jakobsen
Modified: 2014-09-30 02:17 UTC (History)
2 users (show)

See Also:
amdmi3: maintainer-feedback+

Attachments
volman.patch (1.55 KB, text/plain)
2014-09-22 02:17 UTC, Uffe Jakobsen 		no flags Details
volman.patch (1.47 KB, patch)
2014-09-26 22:42 UTC, Uffe Jakobsen 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uffe Jakobsen 2014-09-22 02:17:43 UTC 
Created attachment 147547 [details]
volman.patch

Maintainer (and creator) has stepped down and passed (github) project over
(original location https://github.com/jmptbl/volman/)
You should be able to verify this with original maintainer as he still answers emails 

See conversation: https://github.com/uffejakobsen/volman/issues/1

The attached patch incorpotates new maintainer and download location into Makefile
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-22 02:17:43 UTC 
Maintainer CC'd
Comment 2 Aragon Gouveia 2014-09-22 07:24:34 UTC 
Hi.  Just confirming Uffe as the new maintainer of volman.  Thanks, Uffe. :)
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2014-09-23 18:23:21 UTC 
Please use USE_GITHUB - this provides correct distname and simplifies the port.
Comment 4 Uffe Jakobsen 2014-09-24 18:51:39 UTC 
Well I tried and it did not work - and even if it worked the port got longer than the current.

But maybe you can help me out here ?

I did put this into the port:

USE_GITHUB=	yes
GH_ACCOUNT=	uffejakobsen
GH_PROJECT= ${PORTNAME}
GH_TAGNAME= ${PORTVERSION}
GH_COMMIT=  ee46108

the GH_COMMIT hash ee46108 is what github shows for the "0.7" tag - see url:  https://github.com/uffejakobsen/volman/tags

But that is not the hash found inside the downloaded zip (c420cd5) - in full length the dir below work dir is named "uffejakobsen-volman-c420cd5"

Can you explain where that hash (c420cd5) is originating from ?
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2014-09-24 21:56:09 UTC 
That is hash of tag object (as opposing to hash of commit tag points to).

You can get it with `git show-ref`:

% git show-ref 0.7
c420cd5d7fe1a1b0caccff7ead10ba66ed01f2bd refs/tags/0.7
Comment 6 Uffe Jakobsen 2014-09-24 22:30:15 UTC 
Ok thanks - I'll take a look

The description in porters handbook - is not at all clear (to me at least):

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-description
Comment 7 Uffe Jakobsen 2014-09-26 22:42:03 UTC 
Created attachment 147705 [details]
volman.patch
Comment 8 Uffe Jakobsen 2014-09-26 22:44:41 UTC 
new patch attached

patch also fixes nonworking service stop 

command: service volmand stop

command above previously did not work
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-09-30 02:14:41 UTC 
A commit references this bug:

Author: amdmi3
Date: Tue Sep 30 02:13:59 UTC 2014
New revision: 369568
URL: https://svnweb.freebsd.org/changeset/ports/369568

Log:
  - Pass maintainership to submitter
  - Switch to USE_GITHUB
  - Switch to submitter's GH account as he's willing to maintain the project from now on

  PR:		193823
  Submitted by:	uffe@uffe.org
  Approved by:	aragon@phat.za.net (old maintainer and original author)

Changes:
  head/sysutils/volman/Makefile
  head/sysutils/volman/distinfo
  head/sysutils/volman/files/volmand.in
Comment 10 Dmitry Marakasov freebsd_committer freebsd_triage 2014-09-30 02:17:51 UTC 
Committed with minor changes:
- Fix (by not overriding default) distname
- Remove some more useless assignments
- Whitespace fix