Bug 193836 - [PATCH] devel/boost-libs fails to build on armv6
Summary: [PATCH] devel/boost-libs fails to build on armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: Sean Bruno
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-22 13:52 UTC by Andrew Turner
Modified: 2014-09-26 13:53 UTC (History)
3 users (show)

See Also:
Andrew: maintainer-feedback? (office)

Attachments
Patch to use the compiler to build the asm files (1005 bytes, patch)
2014-09-22 13:52 UTC, Andrew Turner 		no flags Details | Diff
${CC} is preferred in ports to cc (299 bytes, patch)
2014-09-25 03:59 UTC, Sean Bruno 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Turner freebsd_committer freebsd_triage 2014-09-22 13:52:42 UTC 
Created attachment 147559 [details]
Patch to use the compiler to build the asm files

The boost-libs port fails on armv6 as it attempts to use the assembler directly when the files contain pre-processor directives.

The attached patch passes these files through the compiler as is done in the base system.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-22 13:52:42 UTC 
Auto-assigned to maintainer office@FreeBSD.org
Comment 2 Sean Bruno freebsd_committer freebsd_triage 2014-09-22 16:44:15 UTC 
Take for testing and commits.
Comment 3 Sean Bruno freebsd_committer freebsd_triage 2014-09-23 14:42:49 UTC 
Redports build.  I don't see anything new being broken, but tinderbox/redports doesn't handle boost-libs very well.
Comment 5 Remko Lodder freebsd_committer freebsd_triage 2014-09-23 14:53:10 UTC 
The port seems to build in my localsetup. I need to modify the pkg repository so that it can fetch the local package. Will report back later.
Comment 6 Remko Lodder freebsd_committer freebsd_triage 2014-09-23 20:10:58 UTC 
The patch from Andrew seems to build a working package 

<logsnippet>
[1/5] Installing icu-53.1: 100%
[2/5] Installing boost-libs-1.55.0_3: 100%
</logsnippet>

Ofcourse I need to check whether everything went fine, but at least it builds and can be fetched via a local pkg repository.
Comment 7 Bryan Drewery freebsd_committer freebsd_triage 2014-09-24 21:06:32 UTC 
Shouldn't that be CC? Or even ${CXX} from user's environment?
Comment 8 Sean Bruno freebsd_committer freebsd_triage 2014-09-25 03:59:22 UTC 
Created attachment 147654 [details]
${CC} is preferred in ports to cc

Test built on ARMv6 and it seems happy.  pkg built, without incident.
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-09-26 13:48:38 UTC 
A commit references this bug:

Author: sbruno
Date: Fri Sep 26 13:48:28 UTC 2014
New revision: 369325
URL: http://svnweb.freebsd.org/changeset/ports/369325

Log:
  The boost-libs port fails on armv6 as it attempts to use the assembler directly
  when the files contain pre-processor directives.

  The attached patch passes these files through the compiler as is done in the
  base system.

  PR:		193836
  Submitted by:	andrew
  Approved by:	bapt (mentor)

Changes:
  head/devel/boost-libs/Makefile
  head/devel/boost-libs/files/patch-boost__libs__context__build__Jamfile.v2