Bug 193878 - Mk/Scripts/qa.sh: accept /compat/linux/* as valid shebang
Summary: Mk/Scripts/qa.sh: accept /compat/linux/* as valid shebang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2014-09-23 16:22 UTC by Jan Beich
Modified: 2014-10-03 18:48 UTC (History)
2 users (show)

See Also:
mva: maintainer-feedback? (portmgr)

Attachments
fix (331 bytes, patch)
2014-09-23 16:22 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2014-09-23 16:22:58 UTC 
Created attachment 147604 [details]
fix

linux-* port may not want native shebang. For one, linux-tor-browser uses linux bash to avoid having handle cases like |getconf LONG_BIT|.

$ echo OVERRIDE_LINUX_BASE_PORT=c6 ${__MAKE_CONF:-/etc/make.conf}
$ echo OVERRIDE_LINUX_NONBASE_PORTS=c6 >>${__MAKE_CONF:-/etc/make.conf}
$ svn co https://trillian.chruetertee.ch/svn/freebsd-gecko/trunk/www/linux-tor-browser
$ cd linux-tor-browser
$ fgrep bash Makefile
bash_CMD=       ${LINUXBASE}/bin/bash
$ DEVELOPER=1 make BATCH=
...
====> Running Q/A tests (stage-qa)
Error: '/compat/linux/bin/bash' is an invalid shebang you need USES=shebangfix for 'lib/linux-tor-browser/Browser/start-tor-browser'
*** Error code 1
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2014-10-02 20:14:53 UTC 
Assign to maintainer
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-10-03 18:48:19 UTC 
A commit references this bug:

Author: bdrewery
Date: Fri Oct  3 18:47:48 UTC 2014
New revision: 369928
URL: https://svnweb.freebsd.org/changeset/ports/369928

Log:
  - Allow LINUXBASE for shebangs.

  PR:		193878
  Submitted by:	Jan Beich <jbeich@vfemail.net>
  With hat:	portmgr

Changes:
  head/Mk/Scripts/qa.sh