Bug 193960 - [NEW PORT] textproc/py-python-augeas: Pure python bindings for Augeas
Summary: [NEW PORT] textproc/py-python-augeas: Pure python bindings for Augeas
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2014-09-26 20:09 UTC by Johan Ström
Modified: 2015-01-19 02:23 UTC (History)
0 users

See Also:


Attachments
textproc/py-augeas shar (1.50 KB, text/plain)
2014-09-26 20:10 UTC, Johan Ström
no flags Details
Testport output from 10.0-amd64 (13.78 KB, text/plain)
2014-09-26 20:10 UTC, Johan Ström
no flags Details
textproc/py-augeas shar (1.50 KB, text/plain)
2014-09-27 14:24 UTC, Johan Ström
no flags Details
cleaned up py-augeas.shar (1.52 KB, text/plain)
2014-09-28 11:07 UTC, Johan Ström
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Ström 2014-09-26 20:09:15 UTC
Pure python bindings for augeas

WWW: https://github.com/hercules-team/python-augeas
Comment 1 Johan Ström 2014-09-26 20:10:00 UTC
Created attachment 147701 [details]
textproc/py-augeas shar
Comment 2 Johan Ström 2014-09-26 20:10:46 UTC
Created attachment 147702 [details]
Testport output from 10.0-amd64
Comment 3 Johan Ström 2014-09-26 20:11:37 UTC
Initial porting work made by Andrew Childs: 
https://github.com/thefloweringash/freebsd-ports-misc/tree/master/textproc/py-augeas
Comment 4 Johan Ström 2014-09-27 14:24:29 UTC
Created attachment 147727 [details]
textproc/py-augeas shar

Updated shar with me as maint instead of original author.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-28 00:25:37 UTC
Thanks for your submission Johan!

Review:

 * Use USE_GITHUB and GH_* variables (See: Mk/bsd.sites.mk)
 * Use v0.5.0 for GH_TAGNAME (not direct to commit hash)
 * PORTREVISION for a new port unnecessary
 * Add LICENSE_FILE if a standalone license file comes with the distribution
 * Tab align USE{S} section values 
 * pkg-descr: WWW: URL location is http://augeas.net as per setup.py
 * Capitalize Augeas in COMMENT

Please also:

 * Attach portlint -AC output (after addressing any outstanding issues)
Comment 6 Johan Ström 2014-09-28 11:07:10 UTC
Created attachment 147746 [details]
cleaned up py-augeas.shar

Thanks for the feedback! It has now been cleaned up.

I had to override WRKSRC, since bsd.ports.mk would set it to ${WRKDIR}/${GH_ACCOUNT}-${GH_PROJECT}-${GH_COMMIT}. Is this correct?

portlint -AC says "looks fine."
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-01-02 11:40:02 UTC
A commit references this bug:

Author: koobs
Date: Fri Jan  2 11:39:54 UTC 2015
New revision: 376043
URL: https://svnweb.freebsd.org/changeset/ports/376043

Log:
  [NEW] textproc/py-python-augeas: Pure python bindings for Augeas

  Pure python bindings for Augeas

  PR:		193960
  Submitted by:	johan at stromnet se

Changes:
  head/textproc/Makefile
  head/textproc/py-python-augeas/
  head/textproc/py-python-augeas/Makefile
  head/textproc/py-python-augeas/distinfo
  head/textproc/py-python-augeas/pkg-descr
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2015-01-02 11:44:06 UTC
Apologies for the delay Johan.

I committed your patch with a few more changes:

- Add GH_COMMIT, which points to the git hash, which answers your question about WRKSRC overrides in comment 6. The answer was actually in your question :)

- Add regression-test: target to run the unit tests and QA

Most importantly, I changed portname to match the upstream (pypi) name (python-augeas).

This while not a strict policy, is something the Python team will likely be standardizing on going forwards. It helps users find the right packages they want, assists with google juice, and prevents conflicts.

Thanks again for your submission! Looking forward to the next one.
Comment 9 Johan Ström 2015-01-18 11:23:53 UTC
Thanks for the fixes, I'll keep that in mind for my next submission! :)