Created attachment 147734 [details] shar file for the misc/countdown port countdown counts down a specified time interval, then beeps and exits.
- For PORTVERSIONs that use dates, YYYYMMDD format is preferred, i.e. drop the periods - deskutils would probably be a better category - Use MAN1PREFIX instead of PREFIX to install the manpage - files/patch-Makefile is unnecessary because the do-install target overrides the install target in the source Makefile
Created attachment 147751 [details] Shar file for the deskutils/countdown (formerly misc/countdown) port Responding to comment #1, I created an updated shar file addressing your concerns. The changes I made were: * Changed the category from misc to deskutils * Changed the PORTVERSION to YYYYMMDD format * Switched the manpage installation from PREFIX to MAN1PREFIX * Removed the install: target from the Makefile
(In reply to neel from comment #2) > Created attachment 147751 [details] > Updated shar file for the deskutils/countdown (formerly misc/countdown) port > > Responding to comment #1, I created an updated shar file addressing your > concerns. The changes I made were: > * Removed the install: target from the Makefile I meant just remove the whole patch and the files directory altogether. Since you have a do-install target in the port Makefile, the install target in the source Makefile is ignored.
Created attachment 147786 [details] deskutils/countdown shar file without "files" directory Looking at Comment #3, I made the changes.
Created attachment 147803 [details] Stock Makefile for the deskutils/countdown port I forgot to mention this: responding to Comment #4, my experience shows that the stock Makefile for countdown runs "make install" even if I just unzip the tar.gz archive and type in "make" without any arguments. I did attach countdown's original Makefile (came from the .tar.gz itself - not modified) for you to see why I had the Makefile patch in Attachment 147751 [details].
(In reply to neel from comment #5) > Created attachment 147803 [details] > Stock Makefile for the deskutils/countdown port > > I forgot to mention this: responding to Comment #4, my experience shows that > the stock Makefile for countdown runs "make install" even if I just unzip > the tar.gz archive and type in "make" without any arguments. > > I did attach countdown's original Makefile (came from the .tar.gz itself - > not modified) for you to see why I had the Makefile patch in Attachment > 147751 [details]. If you ran "make install" inside the source directory, then make will use that target, yes. If you run "make" in the port directory, however, it will use what you have in the do-install target. If that is not the case, something is seriously wrong. Because of staging, if you run "make" without arguments in the port directory, it will install into the stage directory automatically. "make install" will install what is in the stage directory to the system. I did fail to notice that CC, CFLAGS, and LDFLAGS are not being respected in the source Makefile. I guess there needs to be a patch anyways. CC should be defined with a ?= CFLAGS should be defined with a += (and remove -O too so we are not forcing optimizations) LDFLAGS line should just be deleted since the stripping will be done automatically by INSTALL_PROGRAM
Created attachment 147807 [details] Updated shar file for the deskutils/countdown port Referring to comment #6, I think you are correct. I might have used "make install" on the stock countdown before writing the FreeBSD port for countdown. On the positive note, I did change the CC to CC?= and the CFLAGS to CFLAGS+=. Sorry for these mistakes, but I'm new to contributing FreeBSD ports. Keep in mind that I attached the updated shar file for the deskutils/countdown port.
May as well ignore vendor Makefile altogether by defining MAKEFILE= /dev/null ALL_TARGET= ${PORTNAME} because the following is redefinition of implicit target (bmake or gmake): countdown: countdown.c $(CC) $(CFLAGS) countdown.c $(LDFLAGS) -o countdown Or at least keep respecting LDFLAGS provided by either make.conf, Makefile.local or environment.
Created attachment 147942 [details] Updated shar file for the deskutils/countdown - Ignores Vendor Makefile I updated the port to ignore the vendor Makefile.
@Neel : Still interested by making this port ?
(In reply to Rodrigo Osorio from comment #10) > @Neel : Still interested by making this port ? Yes, I still have interest. Thanks, Neel
A commit references this bug: Author: rodrigo Date: Fri Dec 26 13:57:55 UTC 2014 New revision: 375622 URL: https://svnweb.freebsd.org/changeset/ports/375622 Log: Add new port : countdown, who counts down a specific delay, beep, and exit. PR: ports/193978 Submitted by: neel@neelc.org Changes: head/deskutils/Makefile head/deskutils/countdown/ head/deskutils/countdown/Makefile head/deskutils/countdown/distinfo head/deskutils/countdown/files/ head/deskutils/countdown/files/patch-Makefile head/deskutils/countdown/pkg-descr
committed, thanks.