Bug 194151 - deskutils/griffith missing py-lxml dependency
Summary: deskutils/griffith missing py-lxml dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-04 23:06 UTC by ktullavik
Modified: 2014-11-10 19:34 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ktullavik 2014-10-04 23:06:00 UTC 
Installed with pkg. The py-lxml dependency is missing.

Traceback (most recent call last):
  File "/usr/local/bin/griffith", line 275, in source_changed
    add.source_changed(self)
  File "/usr/local/share/griffith/lib/add.py", line 327, in source_changed
    plugin = __import__(plugin_name)
  File "/usr/local/share/griffith/lib/plugins/movie/PluginMovieAniDB.py", line 30, in <module>
    from lxml import etree
ImportError: No module named lxml
Comment 1 John Marino freebsd_committer freebsd_triage 2014-10-27 16:01:17 UTC 
No, it's not.  Check the makefile:

OPTIONS_DEFINE=	CHARDET LXML PYGNOMEEXTRAS REPORTLAB2    

CHARDET_DESC=		chardet support
CHARDET_RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}chardet>=0:${PORTSDIR}/textproc/py-chardet

LXML_DESC=		lxml support
LXML_RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}lxml>=0:${PORTSDIR}/devel/py-lxml


That means LXML is an optional dependency (option off by default).


Maybe it shouldn't be an option if it's required always, don't know, but the port lists the dependency.
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-11-10 19:34:09 UTC 
A commit references this bug:

Author: marino
Date: Mon Nov 10 19:33:37 UTC 2014
New revision: 372410
URL: https://svnweb.freebsd.org/changeset/ports/372410

Log:
  deskutils/griffith: Set LXML option by default

  This port is unmaintained.  The referenced PR indicates that LXML
  dependency is not actually optional and run-time files if it's not
  installed.  If true, it should be installed unconditionally, but as
  a half-measure, I'll just switch the option to fix it for standard
  binary packages, and let the future maintainer look into this more.

  PR:		194151
  Submitted by:	ktullavik (gmail)

Changes:
  head/deskutils/griffith/Makefile
Comment 3 John Marino freebsd_committer freebsd_triage 2014-11-10 19:34:57 UTC 
maybe that will fix it in practical terms.