Bug 194212 - [NEW PORT] devel/libr3 - URL router library with high performance
Summary: [NEW PORT] devel/libr3 - URL router library with high performance
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2014-10-07 09:49 UTC by Gasol Wu
Modified: 2014-11-28 12:04 UTC (History)
2 users (show)

See Also:


Attachments
shell archive (2.13 KB, text/plain)
2014-10-07 09:49 UTC, Gasol Wu
no flags Details
shell archive (2.40 KB, text/plain)
2014-10-07 13:29 UTC, Gasol Wu
no flags Details
pkg-plist (179 bytes, text/plain)
2014-10-07 17:44 UTC, Gasol Wu
no flags Details
shell archive (2.07 KB, text/plain)
2014-11-10 15:16 UTC, Gasol Wu
no flags Details
poudriere log (32.06 KB, text/plain)
2014-11-10 15:16 UTC, Gasol Wu
no flags Details
shell archive (2.25 KB, text/plain)
2014-11-13 10:34 UTC, Gasol Wu
no flags Details
poudriere log (32.73 KB, text/plain)
2014-11-13 10:34 UTC, Gasol Wu
no flags Details
shell archive (2.17 KB, text/plain)
2014-11-13 10:48 UTC, Gasol Wu
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gasol Wu 2014-10-07 09:49:15 UTC
Created attachment 148056 [details]
shell archive

R3 is an URL router library with high performance, thus, it's implemented in C.
It compiles your route paths into a prefix trie.

By using the constructed prefix trie in the start-up time, you can dispatch
routes with efficiency.

WWW: https://github.com/c9s/r3
Comment 1 Gasol Wu 2014-10-07 13:29:36 UTC
Created attachment 148059 [details]
shell archive

new shar files attached, use this one instead.
Comment 2 Gasol Wu 2014-10-07 17:44:16 UTC
Created attachment 148074 [details]
pkg-plist

Add missing file `lib/libr3.so.0.0.0`, Use this pkg-plist instead.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-10-31 19:03:14 UTC
er, no.

Please submit a new shar with the new pkg-plist and make sure all 3 of the previous attachments are obsolete.  It's an option when you upload attachments.  What you have here is highly confusing.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-10-31 19:04:20 UTC
oh, and make sure you upload a poudriere test log with stage-qa checks (bulk -t or testport) to prove that it's error free.
Comment 5 Gasol Wu 2014-11-10 15:16:03 UTC
Created attachment 149261 [details]
shell archive
Comment 6 Gasol Wu 2014-11-10 15:16:47 UTC
Created attachment 149262 [details]
poudriere log
Comment 7 John Marino freebsd_committer freebsd_triage 2014-11-10 15:51:51 UTC
two problems:

1) You generated the shar in "." instead of the directory above (same as other port)

2) X@comment $FreeBSD$

No, remove that line.  Were did that line in pkg-plist come from?  That's not been done in a long time.
Comment 8 Gasol Wu 2014-11-11 04:25:45 UTC
Okay, I will correct the method next time, I always use command `port create` to generate port template. So I think $FreeBSD$ is come from it.
Comment 9 John Marino freebsd_committer freebsd_triage 2014-11-11 07:16:11 UTC
Your ports are not up to date.  I think you need to update devel/newfile.

http://www.freshports.org/commit.php?category=devel&port=newfile&files=yes&message_id=201410171438.s9HEcQ0Q083100@svn.freebsd.org
Comment 10 Gasol Wu 2014-11-13 10:34:19 UTC
Created attachment 149365 [details]
shell archive

- Strip shared library
- Remove cvs tag
Comment 11 Gasol Wu 2014-11-13 10:34:56 UTC
Created attachment 149366 [details]
poudriere log
Comment 12 John Marino freebsd_committer freebsd_triage 2014-11-13 10:36:29 UTC
Comment on attachment 149365 [details]
shell archive

it's a shar, not patch
Comment 13 John Marino freebsd_committer freebsd_triage 2014-11-13 10:39:09 UTC
Look ok.  The only thing I would change is putting parenthesis around "cd ${WRKSRC} && ./autogen.sh".  I'm promoting the PR.  It would be nice to update the shar with the parenthesis if you can, otherwise the committer will have to remember to do it.
Comment 14 Gasol Wu 2014-11-13 10:48:18 UTC
Created attachment 149369 [details]
shell archive

- Putting parenthesis around shell command
Comment 15 Gasol Wu 2014-11-13 10:49:07 UTC
Thanks for your advice and patient.
Comment 16 commit-hook freebsd_committer freebsd_triage 2014-11-28 12:03:38 UTC
A commit references this bug:

Author: marino
Date: Fri Nov 28 12:02:37 UTC 2014
New revision: 373562
URL: https://svnweb.freebsd.org/changeset/ports/373562

Log:
  Add new port devel/libr3

  PR:		194212
  Submitted by:	Gasol Wu

  R3 is an URL router library with high performance implemented in C. It
  compiles route paths into a prefix trie.  By using the constructed prefix
  trie in the start-up time, you can dispatch routes with efficiency.

Changes:
  head/devel/Makefile
  head/devel/libr3/
  head/devel/libr3/Makefile
  head/devel/libr3/distinfo
  head/devel/libr3/pkg-descr
  head/devel/libr3/pkg-plist
Comment 17 John Marino freebsd_committer freebsd_triage 2014-11-28 12:04:16 UTC
Enjoy your new port!