Bug 194370 - [MAINTAINER] mail/bsfilter: remove @dirrm from pkg-plist
Summary: [MAINTAINER] mail/bsfilter: remove @dirrm from pkg-plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-15 04:58 UTC by Yasuhiro Kimura
Modified: 2014-10-18 06:53 UTC (History)
1 user (show)

See Also:

Attachments
Remove @dirrm from pkg-plist. (1.67 KB, patch)
2014-10-15 04:58 UTC, Yasuhiro Kimura 		no flags Details | Diff
Updated patch. (1.64 KB, patch)
2014-10-16 23:05 UTC, Yasuhiro Kimura 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2014-10-15 04:58:59 UTC 
Created attachment 148327 [details]
Remove @dirrm from pkg-plist.

* Remove @dirrm from pkg-plist.
* Pet portlint.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-10-16 08:41:56 UTC 
comment 1)  you can leave this command masked,  you don't need to change it:
${MKDIR} ${STAGEDIR}${EXAMPLESDIR}


comment 2)
use ${COPYTREE_SHARE} for this line:
${CP} -r ${WRKSRC}/${DIR} ${STAGEDIR}${EXAMPLESDIR}/${DIR}

Unless there is concrete justification for using ${CP}, don't use it.

Can you make those changes and resubmit?
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2014-10-16 23:05:48 UTC 
Created attachment 148382 [details]
Updated patch.

Thank you comments.

I updated patch, so please commit it instead of original one.

Regards.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-10-18 06:47:46 UTC 
A commit references this bug:

Author: marino
Date: Sat Oct 18 06:47:26 UTC 2014
New revision: 371093
URL: https://svnweb.freebsd.org/changeset/ports/371093

Log:
  mail/bsfilter: Remove @dirrm, unmask cmds, use COPYTREE over CP

  PR:		194370
  submitted by:	maintainer (Yasuhiro KIMURA)

Changes:
  head/mail/bsfilter/Makefile
  head/mail/bsfilter/pkg-plist
Comment 4 John Marino freebsd_committer freebsd_triage 2014-10-18 06:53:33 UTC 
Thanks!