Bug 194408 - multimedia/mpv: respect -O level in CFLAGS
Summary: multimedia/mpv: respect -O level in CFLAGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Grzegorz Blach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-16 18:42 UTC by Jan Beich
Modified: 2014-10-27 00:52 UTC (History)
1 user (show)

See Also:
gblach: maintainer-feedback+

Attachments
disable -O2 from vendor (425 bytes, patch)
2014-10-16 18:42 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2014-10-16 18:42:59 UTC 
Created attachment 148378 [details]
disable -O2 from vendor

There's an audio issue due to a compiler bug on 11.0-CURRENT i386. It took me a while to figure out because the port ignores CFLAGS+=-O0 by passing -O2 later. Let's drop vendor optimization in favor of system-specific (environ, make.conf, Makefile.local).

Affects since v0.5.0 (r364818) or b0ff052.

$ mpv --no-config /path/to/foo.aac
...
AO: [oss] 44100Hz stereo 2ch s32
Unable to convert audio input format to output format.
Audio filter chain:
  [in] 44100Hz stereo 2ch floatp
  [out] 44100Hz stereo 2ch s32 <-
  [ao] 44100Hz stereo 2ch s32
Could not create audio filter chain.
Couldn't find matching filter/ao format!
Audio: no audio

To reproduce check the log for any -O after:

  $ make clean all WITH_DEBUG= _MAKE_JOBS=-v
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-10-16 18:42:59 UTC 
Auto-assigned to maintainer gblach@FreeBSD.org
Comment 2 Jan Beich freebsd_committer freebsd_triage 2014-10-16 18:47:20 UTC 
Ports infrastructure by default inherits -O2 -pipe -fno-strict-aliasing from /usr/share/mk/sys.mk. The patch allows user to build mpv with -O0, -O3, etc.
Comment 3 Grzegorz Blach freebsd_committer freebsd_triage 2014-10-27 00:52:22 UTC 
Committed, thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-10-27 00:52:39 UTC 
A commit references this bug:

Author: gblach
Date: Mon Oct 27 00:51:39 UTC 2014
New revision: 371530
URL: https://svnweb.freebsd.org/changeset/ports/371530

Log:
  Disable -O2 from vendor

  PR:		194408
  Submitted by:	Jan Beich (jbeich <at> vfemail <dot> net)

Changes:
  head/multimedia/mpv/Makefile