Bug 194559 - devel/mico: resurrect
Summary: devel/mico: resurrect
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-23 15:56 UTC by Pedro F. Giffuni
Modified: 2014-11-23 16:23 UTC (History)
1 user (show)

See Also:


Attachments
"svn diff" for devel/mico (24.20 KB, patch)
2014-10-23 15:56 UTC, Pedro F. Giffuni
no flags Details | Diff
devel/mico shar file (51.49 KB, text/plain)
2014-10-23 15:57 UTC, Pedro F. Giffuni
no flags Details
Fix plist and EXAMPLES option. (59.34 KB, patch)
2014-11-01 14:59 UTC, Thierry Thomas
no flags Details | Diff
devel/mico shar file (45.75 KB, text/plain)
2014-11-01 23:59 UTC, Pedro F. Giffuni
no flags Details
devel/mico shar file (46.33 KB, text/plain)
2014-11-02 01:41 UTC, Pedro F. Giffuni
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni freebsd_committer freebsd_triage 2014-10-23 15:56:22 UTC
Created attachment 148584 [details]
"svn diff" for devel/mico

- Update to version 2.3.13
- Port to clang.
- Support staging.

This port had been removed and the "svn diff" I am attaching involves restoring it back first. I will be submitting a shar file soon after.

It should be easy to restore devel/combat but I am currently only interested in helping restoring OpenFOAM (in the WantedPorts wiki).
Comment 1 Pedro F. Giffuni freebsd_committer freebsd_triage 2014-10-23 15:57:47 UTC
Created attachment 148585 [details]
devel/mico shar file

Here is the complete shar file for reference.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-11-01 11:54:57 UTC
This is not going to work on many levels.

1) it's against policy to resurrect without a maintainer.  This can't be left for ports@FreeBSD.org
2) there are patches for freebsd 5 and 6, those should be cleaned up
3) The options need to be updated to the current framework
4) I doubt the pkg-plist completely conforms with standard

logs? portlint?
And I do appreciate the reference shar, I'd probably want to see the "new" shar even more.

I can't promote this in it's current state.  Some committer would have to take it over on his own (and the above issues still need to be addressed)
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2014-11-01 14:59:08 UTC
Created attachment 148875 [details]
Fix plist and EXAMPLES option.

I already did some clean-up (see the attached patch) to fix plist and the DOCS / EXAMPLES options.

But there is also a staging error:

Error: Bad symlink 'lib/libmico2.3.13.so.1' pointing inside the stage directory
Error: Bad symlink 'lib/libmicoaux2.3.13.so.1' pointing inside the stage directory
Error: Bad symlink 'lib/libmicoccm2.3.13.so.1' pointing inside the stage directory
Error: Bad symlink 'lib/libmicocoss2.3.13.so.1' pointing inside the stage directory
Error: Bad symlink 'lib/libmicoir2.3.13.so.1' pointing inside the stage directory
Comment 4 Pedro F. Giffuni freebsd_committer freebsd_triage 2014-11-01 19:37:08 UTC
(In reply to Thierry Thomas from comment #3)
> Created attachment 148875 [details]
> Fix plist and EXAMPLES option.
> 
> I already did some clean-up (see the attached patch) to fix plist and the
> DOCS / EXAMPLES options.
>

Thank you. I am addressing the rest of marino's issues.
 
> But there is also a staging error:
> 
> Error: Bad symlink 'lib/libmico2.3.13.so.1' pointing inside the stage
> directory
> Error: Bad symlink 'lib/libmicoaux2.3.13.so.1' pointing inside the stage
> directory
> Error: Bad symlink 'lib/libmicoccm2.3.13.so.1' pointing inside the stage
> directory
> Error: Bad symlink 'lib/libmicocoss2.3.13.so.1' pointing inside the stage
> directory
> Error: Bad symlink 'lib/libmicoir2.3.13.so.1' pointing inside the stage
> directory

Interesting. this is because the port is shooting itself in the foot:
...
post-install:
	for i in `${GREP} '^lib/lib.*so$$' ${TMPPLIST}`; do \
		${LN} -fs ${STAGEDIR}${PREFIX}/$$i ${STAGEDIR}${PREFIX}/$$i.1; \
	done; \
___

I will try to rename them to something more sensible like:
lib/libmicoir.so.2.3.13
Comment 5 Pedro F. Giffuni freebsd_committer freebsd_triage 2014-11-01 23:59:31 UTC
Created attachment 148909 [details]
devel/mico shar file

This is WIP.

Generating the shared files correctly is tricky and will be submitted later.
Comment 6 Pedro F. Giffuni freebsd_committer freebsd_triage 2014-11-02 01:41:32 UTC
Created attachment 148910 [details]
devel/mico shar file

Bah.. I just preserved the status quo. This works fine with staging.
I can maintain the package for a while if needed.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-11-07 17:29:00 UTC
X.if ${PORT_OPTIONS:MDOCS}
X	${GMAKE} -C ${WRKSRC} install-doc
X.endif
X.if ${PORT_OPTIONS:MEXAMPLES}
X	${GMAKE} -C ${WRKSRC} install-demo
X.endif


Wouldn't those be done via INSTALL_TARGET+= install-doc install-demo ?

Thierry, do you want to take this ticket?
Comment 8 John Marino freebsd_committer freebsd_triage 2014-11-07 20:20:19 UTC
Thanks!  I'm signing off this one then. Have fun! :)
Comment 9 Thierry Thomas freebsd_committer freebsd_triage 2014-11-23 16:23:39 UTC
Committed, thanks!
And sorry for the delay...
Comment 10 commit-hook freebsd_committer freebsd_triage 2014-11-23 16:23:39 UTC
A commit references this bug:

Author: thierry
Date: Sun Nov 23 16:23:15 UTC 2014
New revision: 373166
URL: https://svnweb.freebsd.org/changeset/ports/373166

Log:
  Resurrect devel/mico, in order to restore OpenFOAM.

  - Update to version 2.3.13
  - Port to clang.
  - Support staging.

  PR:		ports/194559
  Submitted by:	Pedro F. Giffuni <pfg (at) FreeBSD.org>

Changes:
  head/MOVED
  head/devel/Makefile
  head/devel/mico/
  head/devel/mico/Makefile
  head/devel/mico/distinfo
  head/devel/mico/files/
  head/devel/mico/files/patch-Makefile
  head/devel/mico/files/patch-aclocal.m4
  head/devel/mico/files/patch-ccm_componentserver.cc
  head/devel/mico/files/patch-configure.in
  head/devel/mico/files/patch-orb-security-audit_impl.cc
  head/devel/mico/pkg-descr
  head/devel/mico/pkg-plist