Bug 194607 - [patch] net/daq fix build on 8.4 (no netmap support)
Summary: [patch] net/daq fix build on 8.4 (no netmap support)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-26 11:25 UTC by Olli Hauer
Modified: 2014-10-26 12:40 UTC (History)
0 users

See Also:
ohauer: maintainer-feedback? (zi)


Attachments
daq patch for FreeBSD releases without netmap support (1.03 KB, patch)
2014-10-26 11:25 UTC, Olli Hauer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Hauer freebsd_committer freebsd_triage 2014-10-26 11:25:30 UTC
Created attachment 148659 [details]
daq patch for FreeBSD releases without netmap support

On FreeBSD 8.4 the new net/daq port fails if not build with "CONFIGURE_ARGS+=--disable-netmap-module"

Don't know at which OSVERSION netmap is available, please adjust the OSVERSION check.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-10-26 11:25:30 UTC
Auto-assigned to maintainer zi@FreeBSD.org
Comment 2 Ryan Steinmetz freebsd_committer freebsd_triage 2014-10-26 12:25:54 UTC
Olli,

Do you have the failed buildlog handy?  It looks like netmap support is part of 8.4:

https://svnweb.freebsd.org/base/release/8.4.0/sys/dev/netmap/
Comment 3 Olli Hauer freebsd_committer freebsd_triage 2014-10-26 12:39:30 UTC
Hi Ryan,

sorry I forgot to set a link to the logs.

failed build:
http://people.freebsd.org/~ohauer/diffs/daq-2.0.4_failed.log

build with the patch:
http://people.freebsd.org/~ohauer/diffs/daq-2.0.4_OK.log

The failed lines (for reference in case I remove the logs in the future)

.libs/libdaq_static_modules_la-daq_netmap.o
In file included from daq_netmap.c:27:
/usr/include/net/if.h:360: error: field 'ifru_addr' has incomplete type
/usr/include/net/if.h:361: error: field 'ifru_dstaddr' has incomplete type
/usr/include/net/if.h:362: error: field 'ifru_broadaddr' has incomplete type
/usr/include/net/if.h:400: error: field 'ifra_addr' has incomplete type
/usr/include/net/if.h:401: error: field 'ifra_broadaddr' has incomplete type
/usr/include/net/if.h:402: error: field 'ifra_mask' has incomplete type
/usr/include/net/if.h:490: error: field 'addr' has incomplete type
/usr/include/net/if.h:491: error: field 'dstaddr' has incomplete type
daq_netmap.c: In function 'create_instance':
daq_netmap.c:187: error: 'NETMAP_API' undeclared (first use in this function)
daq_netmap.c:187: error: (Each undeclared identifier is reported only once
daq_netmap.c:187: error: for each function it appears in.)
daq_netmap.c: In function 'start_instance':
daq_netmap.c:253: error: 'struct nmreq' has no member named 'nr_tx_rings'
daq_netmap.c:254: error: 'struct nmreq' has no member named 'nr_rx_rings'
daq_netmap.c:259: error: 'struct nmreq' has no member named 'nr_tx_slots'
daq_netmap.c:260: error: 'struct nmreq' has no member named 'nr_rx_slots'
daq_netmap.c:261: error: 'struct nmreq' has no member named 'nr_tx_rings'
daq_netmap.c:262: error: 'struct nmreq' has no member named 'nr_rx_rings'
Makefile:794: recipe for target 'libdaq_static_modules_la-daq_netmap.lo' failed
gmake[2]: *** [libdaq_static_modules_la-daq_netmap.lo] Error 1
gmake[2]: Leaving directory '/wrkdirs/usr/ports/net/daq/work/daq-2.0.4/os-daq-modules'
Makefile:395: recipe for target 'all-recursive' failed
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory '/wrkdirs/usr/ports/net/daq/work/daq-2.0.4'
Makefile:326: recipe for target 'all' failed
gmake: *** [all] Error 2
*** Error code 1
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-10-26 12:40:37 UTC
A commit references this bug:

Author: zi
Date: Sun Oct 26 12:40:11 UTC 2014
New revision: 371502
URL: https://svnweb.freebsd.org/changeset/ports/371502

Log:
  - Disable netmap support on anything older than 9.1
  PR:		194607
  Submitted by:	ohauer@

Changes:
  head/net/daq/Makefile
  head/net/daq/pkg-plist