Created attachment 148674 [details] Shell archive with new port OpenClonk is a free multiplayer action game in which you control clonks, small but witty and nimble humanoid beings. The game is mainly about mining, settling and fast-paced melees. OpenClonk is not just a game but also a versatile 2D game engine that allows the creation of mods. It is the successor of the shareware game series Clonk and thus inherits many of its features. WWW: http://www.openclonk.org/
Created attachment 148675 [details] Poudriere build log on 10amd64
Here's a small issue: OpenClonk installs into ${PREFIX}/games, but that directory is not in PATH by default. The supplied desktop file doesn't use the full path, so the desktop entry is broken on machines without a custom PATH. Possible solutions: - Use full path in desktop file - Install binaries into ${PREFIX}/bin - Something else? I'd be happy to resubmit the port, but I'd like feedback on what should be done.
(In reply to Kevin Zheng from comment #2) > Here's a small issue: OpenClonk installs into ${PREFIX}/games, why? because it wants to? Make it install in bin -- adjust a configure arg or patch if you have to. secondly, the pkg-plist is wrong here: X@dir games X@dir share/games/openclonk X@dir share/games X@dir share/icons/hicolor/128x128/apps X@dir share/icons/hicolor/128x128 X@dir share/icons/hicolor/256x256/apps X@dir share/icons/hicolor/256x256 X@dir share/icons/hicolor/32x32/apps X@dir share/icons/hicolor/32x32 X@dir share/icons/hicolor/512x512/apps X@dir share/icons/hicolor/512x512 X@dir share/icons/hicolor/64x64/apps X@dir share/icons/hicolor/64x64 X@dir share/icons/hicolor X@dir share/icons @dir is not new name for @dirrm or @dirrmtry please review /usr/ports/CHANGES on how to use it. You probably don't need it at all.
Created attachment 148897 [details] Fixed shell archive with new port Thanks for the comments; the issues have been fixed.
Thanks! I'll promote this PR now.
A commit references this bug: Author: marino Date: Tue Nov 4 19:21:53 UTC 2014 New revision: 372165 URL: https://svnweb.freebsd.org/changeset/ports/372165 Log: Add new ports games/openclock PR: 194617 Submitted by: Kevin Zheng OpenClonk is a free multiplayer action game in which you control clonks, small but witty and nimble humanoid beings. The game is mainly about mining, settling and fast-paced melees. OpenClonk is not just a game but also a versatile 2D game engine that allows the creation of mods. It is the successor of the shareware game series Clonk and thus inherits many of its features. Changes: head/games/Makefile head/games/openclonk/ head/games/openclonk/Makefile head/games/openclonk/distinfo head/games/openclonk/pkg-descr head/games/openclonk/pkg-plist
Thanks!
It's unfetchable. MASTER_SITES should be "http://www.openclonk.org/builds/release/${DISTVERSIONPREFIX}${DISTVERSION}/" because at their server it resides in "release/5.5.1" and not in "release/5.1".
90% of the time I test these ports, but not in this case because it came with poudriere log and the distfile was 65M (I'm on data plan). So it figures I got burned. My guess is that this used to work and the Kevin used that distfile prefix thing, broke it, but never noticed because it was already fetched. Poudriere won't catch that either.
Created attachment 149145 [details] Patch to fix fetching Oops, I was fiddling with PORTVERSION but didn't re-test fetching. Attached is a patch that fixes this problem (thanks for pointing it out).
applied, thanks.
Created attachment 149390 [details] C11 fixes (incomplete) It appears that this port only built correctly on amd64 systems running 10+. The attached patch fixes (according to RedPorts) the build for i386 on 10+ systems. The build for 8 and 9 on both i386 and amd64 still seem to be broken; I'm still working on patches to fix it. Meanwhile, should the fix for 10+ i386 be committed, or wait until everything's fixed?
just wait until you have all the fixes -- it's not like anybody is complaining.
and open a new PR for the fixes when you have them