Bug 194853 - [maintainer-update] net-mgmt/ccnet: clean Makefile and add supports to other BSDs
Summary: [maintainer-update] net-mgmt/ccnet: clean Makefile and add supports to other ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-06 04:07 UTC by Jingfeng Yan
Modified: 2014-11-07 02:12 UTC (History)
2 users (show)

See Also:


Attachments
diff from existing port (2.47 KB, patch)
2014-11-06 04:09 UTC, Jingfeng Yan
no flags Details | Diff
diff from existing port (2.53 KB, patch)
2014-11-06 04:11 UTC, Jingfeng Yan
no flags Details | Diff
test port log (188.73 KB, text/plain)
2014-11-06 04:40 UTC, Jingfeng Yan
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jingfeng Yan 2014-11-06 04:07:08 UTC
Based on 193134's input, something in ccnet should be updated to make thing more consistent.

(1) use ${LN} instead of ${INSTALL} for 2nd copy.
(2) __FreeBSD__, __DragonFly__ ... supports

Running poudriere now. Will post result in a while.
Comment 1 Jingfeng Yan 2014-11-06 04:09:43 UTC
Created attachment 149107 [details]
diff from existing port
Comment 2 Jingfeng Yan 2014-11-06 04:11:39 UTC
Created attachment 149108 [details]
diff from existing port
Comment 3 Jingfeng Yan 2014-11-06 04:40:03 UTC
Created attachment 149117 [details]
test port log
Comment 4 John Marino freebsd_committer freebsd_triage 2014-11-06 19:23:43 UTC
FYI, there's no point in supporting __NetBSD__ or __OpenBSD__ until you intend to give the same patches to the upstream source (or pkgsrc).  Only DragonFly and FreeBSD use the ports system.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-11-06 19:33:08 UTC
A commit references this bug:

Author: marino
Date: Thu Nov  6 19:32:45 UTC 2014
New revision: 372231
URL: https://svnweb.freebsd.org/changeset/ports/372231

Log:
  net-mgmt/ccnet: Fix post-install and support other BSDs

  PR:		194853
  Submitted by:	maintainer (Jingfeng Yan)

Changes:
  head/net-mgmt/ccnet/Makefile
  head/net-mgmt/ccnet/files/patch-lib_utils.c
  head/net-mgmt/ccnet/files/patch-net_common_getgateway.c
Comment 6 John Marino freebsd_committer freebsd_triage 2014-11-06 19:34:55 UTC
I tweaked this to look like net-mgmt/seafile.

In the end, it didn't make sense to spend 6 lines on 2 installations, so I removed the loop completely and just had two install lines.
Comment 7 Jingfeng Yan 2014-11-07 02:12:35 UTC
(In reply to John Marino from comment #6)
> I tweaked this to look like net-mgmt/seafile.
> 
> In the end, it didn't make sense to spend 6 lines on 2 installations, so I
> removed the loop completely and just had two install lines.

Thank you for your supports and efforts.