Bug 194868 - x11/xbindkeys with Tcl support requires old version (8.4) of Tcl/Tk
Summary: x11/xbindkeys with Tcl support requires old version (8.4) of Tcl/Tk
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-06 16:32 UTC by wbparsons
Modified: 2014-11-06 18:35 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description wbparsons 2014-11-06 16:32:17 UTC 
If Tcl support is enabled when building xbindkeys, it tries to bring in Tcl/Th 8.4, which is obsolete.  Port should require a current version.  The following patch seems to work, but I don't know enough about how ports are structured to have confidence this is correct:



--- Makefile.orig       2014-09-24 02:00:09.000000000 -0400
+++ Makefile    2014-11-06 10:30:48.000000000 -0500
@@ -22,7 +22,7 @@
 PLIST_FILES=   bin/xbindkeys %%EXAMPLESDIR%%/xbindkeysrc man/man1/xbindkeys.1.gz
 PLIST_DIRS=    %%EXAMPLESDIR%%
 
-WISH=          ${LOCALBASE}/bin/wish8.4
+WISH=          ${LOCALBASE}/bin/wish8.6
 
 .include <bsd.port.options.mk>
 
@@ -33,7 +33,7 @@
 .endif
 
 .if ${PORT_OPTIONS:MTCL}
-RUN_DEPENDS+=  wish8.4:${PORTSDIR}/x11-toolkits/tk84
+RUN_DEPENDS+=  wish8.6:${PORTSDIR}/x11-toolkits/tk86
 PLIST_FILES+=  bin/xbindkeys_show man/man1/xbindkeys_show.1.gz
 .else
 CONFIGURE_ARGS+=       --disable-tk
Comment 1 commit-hook freebsd_committer freebsd_triage 2014-11-06 18:34:01 UTC 
A commit references this bug:

Author: gahr
Date: Thu Nov  6 18:33:55 UTC 2014
New revision: 372229
URL: https://svnweb.freebsd.org/changeset/ports/372229

Log:
  - Do not require a particular version of Tk - any will do [1]
  - While at it, modernize OPTIONS

  PR:		194868
  Submitted by:	wbparsons@alum.mit.edu

Changes:
  head/x11/xbindkeys/Makefile