Bug 194909 - multimedia/plexmediaserver - rc.d simplification
Summary: multimedia/plexmediaserver - rc.d simplification
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Felder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-09 01:05 UTC by joshruehlig
Modified: 2014-11-28 18:33 UTC (History)
0 users

See Also:


Attachments
Patch to plexmediaserver port (7.78 KB, patch)
2014-11-09 01:06 UTC, joshruehlig
no flags Details | Diff
Patch to plexmediaserver port (7.79 KB, patch)
2014-11-09 01:23 UTC, joshruehlig
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description joshruehlig 2014-11-09 01:05:48 UTC
I had a some changes I wanted to submit to simplify some things in the plexmediaserver port. I'll attach a patch to this report.
Comment 1 joshruehlig 2014-11-09 01:06:19 UTC
Created attachment 149216 [details]
Patch to plexmediaserver port
Comment 2 joshruehlig 2014-11-09 01:19:07 UTC
Larger changes in the patch include..

* Not specifying SUPPORT_PATH or SCRIPT_PATH in the Makefile.
- No need to have SUPPORT_PATH defined here when it can just be set in /etc/rc.conf.
- SCRIPT_PATH is just DATADIR I didn't see I reason to rename it unless to make it more portable, but I doubt any users would change this.

* Make a symlink to the "Plex Media Server" binary so the rc.d script could be greatly simplified by using built-in functions.

* Add a pkg-message to be presented to the user upon installation

* substitute in %%PORTNAME%% where most ports would have their portname present
- e.g. before rc variables
Comment 3 joshruehlig 2014-11-09 01:23:17 UTC
Created attachment 149217 [details]
Patch to plexmediaserver port
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2014-11-11 02:23:09 UTC
Fix synopsis and assign to maintainer.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-11-28 18:33:16 UTC
A commit references this bug:

Author: feld
Date: Fri Nov 28 18:32:41 UTC 2014
New revision: 373574
URL: https://svnweb.freebsd.org/changeset/ports/373574

Log:
  Port cleanup and preparation for making -plexpass a slave port to
  prevent duplicate work

  PR:		194909
  Submitted by:	Josh Ruehlig

Changes:
  head/multimedia/plexmediaserver/Makefile
  head/multimedia/plexmediaserver/files/pkg-message.in
  head/multimedia/plexmediaserver/files/plexmediaserver.in
  head/multimedia/plexmediaserver/pkg-plist