Bug 195157 - [PORT net-im/qTox] Maintainer update qTox-0.141118
Summary: [PORT net-im/qTox] Maintainer update qTox-0.141118
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-19 00:53 UTC by Yuri Victorovich
Modified: 2014-11-21 21:54 UTC (History)
1 user (show)

See Also:

Attachments
patch (2.34 KB, patch)
2014-11-19 00:53 UTC, Yuri Victorovich 		no flags Details | Diff
pourfriere log (182.45 KB, text/plain)
2014-11-19 00:54 UTC, Yuri Victorovich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2014-11-19 00:53:48 UTC 
Created attachment 149570 [details]
patch
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2014-11-19 00:54:50 UTC 
Created attachment 149571 [details]
pourfriere log
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2014-11-21 17:12:13 UTC 
Please do not add a dependency on security/libsodium: Tox can be built with this option disabled and switched to NaCl.

To be sure, you could use ${LOCALBASE}/libdata/pkgconfig/libtoxcore.pc but anyway there is no need to add this indirect dependency.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2014-11-21 19:36:55 UTC 
qTox itself is currently inconsistent with libsodium being optional. It uses libsodium directly in main.cpp (sodium_init) and from autoupdate.cpp (crypto_sign_verify_detached), among other places. It will not build without this dependency when toxcore is built without SODIUM option. With it, it will at least (maybe) still work.

I will file the problem report in qTox github asking to fix this. In the meantime, we probably should leave qTox with libsodium dependency.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-11-21 21:53:47 UTC 
A commit references this bug:

Author: thierry
Date: Fri Nov 21 21:53:04 UTC 2014
New revision: 373016
URL: https://svnweb.freebsd.org/changeset/ports/373016

Log:
  Upgrading to 0.141118.

  Note: ATM qTox won't work if Tox has been built with the NACL option!

  PR:		ports/195157
  Submitted by:	yuri (at) rawbw.com (maintainer)

Changes:
  head/net-im/qTox/Makefile
  head/net-im/qTox/distinfo
  head/net-im/qTox/files/patch-qtox.pro