Bug 195359 - [PATCH] sysutils/vpnc-scripts enable use of resolvconf
Summary: [PATCH] sysutils/vpnc-scripts enable use of resolvconf
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-25 01:24 UTC by John Baldwin
Modified: 2015-03-12 16:57 UTC (History)
1 user (show)

See Also:
jhb: maintainer-feedback? (zi)


Attachments
patch-vpnc-script (638 bytes, patch)
2014-11-25 01:24 UTC, John Baldwin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Baldwin freebsd_committer freebsd_triage 2014-11-25 01:24:51 UTC
Created attachment 149811 [details]
patch-vpnc-script

The vpnc-scripts package disables use of resolvconf explicitly on FreeBSD.  I believe this is probably because the built-in resolver in libc doesn't support many fancy features.  However, resolvconf does work fine, and in conjunction with a different local resolver (such as unbound or dnsmasq) resolvconf can correctly manage things like split DNS.  The patch enables use of resolvconf on FreeBSD and should probably go upstream as well.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-25 01:24:51 UTC
Auto-assigned to maintainer zi@FreeBSD.org
Comment 2 Ryan Steinmetz freebsd_committer freebsd_triage 2015-01-06 01:30:31 UTC
Chatting about this with the vpnc-scripts dev.
Comment 3 dwmw2 2015-01-06 07:49:19 UTC
I think the reason it was disabled on FreeBSD was probably because the contributor couldn't easily test it and it looked different, so they erred on the side of caution. Apologies; I should have been paying more attention and made sure at the time.

If you lot are going to tell me it's fine to use it on all versions of FreeBSD then I'm certainly happy with that. Please can I see a Signed-off-by: tag for the patch?
Comment 4 John Baldwin freebsd_committer freebsd_triage 2015-01-06 14:21:15 UTC
(In reply to dwmw2 from comment #3)

No problem at all.  I have certainly used it on 10.x and head with vpnc-scripts personally (both with openconnect and vpnc).  It looks like all versions of FreeBSD that support resolvconf use the same version, so you should be fine to enable it on FreeBSD unconditionally.  It is actually an external package called openresolv which is hosted here: http://roy.marples.name/projects/openresolv/index
Comment 5 John Baldwin freebsd_committer freebsd_triage 2015-02-07 16:32:45 UTC
To be clear, you can use 'Signed-off-by: John Baldwin <jhb@FreeBSD.org>'.
Comment 6 dwmw2 2015-03-12 15:30:58 UTC
http://git.infradead.org/users/dwmw2/vpnc-scripts.git/commitdiff/befa4afdf0a

Thanks. Apologies for the delay.
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-03-12 15:37:14 UTC
A commit references this bug:

Author: zi
Date: Thu Mar 12 15:36:22 UTC 2015
New revision: 381107
URL: https://svnweb.freebsd.org/changeset/ports/381107

Log:
  - Enable use of resolveconf

  PR:		195359
  Submitted by:	John Baldwin <jhb@FreeBSD.org>

Changes:
  head/sysutils/vpnc-scripts/Makefile
  head/sysutils/vpnc-scripts/files/
  head/sysutils/vpnc-scripts/files/patch-vpnc-script
Comment 8 John Baldwin freebsd_committer freebsd_triage 2015-03-12 16:57:01 UTC
(In reply to dwmw2 from comment #6)

No problem.  Thanks!