Bug 195524 - [PATCH] mail/spamassassin Lint errors with latest ruleset / patch from upstream
Summary: [PATCH] mail/spamassassin Lint errors with latest ruleset / patch from upstream
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-30 10:42 UTC by Bernard Spil
Modified: 2014-12-01 08:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (adamw)

Attachments
Backport of upstream patch (1.40 KB, patch)
2014-11-30 10:42 UTC, Bernard Spil 		no flags Details | Diff
Build log (116.36 KB, text/plain)
2014-11-30 10:43 UTC, Bernard Spil 		no flags Details
Patch for Makefile (442 bytes, patch)
2014-11-30 10:46 UTC, Bernard Spil 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer freebsd_triage 2014-11-30 10:42:36 UTC 
Created attachment 150020 [details]
Backport of upstream patch

There's a bug in recent spamassassin versions causing lint errors in output.
This is a nuisance for people running crontab ruleset-updates or learning scripts.

Upstream patch https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7107
Patchset http://svn.apache.org/viewvc?view=revision&revision=1642207
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-30 10:42:36 UTC 
Auto-assigned to maintainer adamw@FreeBSD.org
Comment 2 Bernard Spil freebsd_committer freebsd_triage 2014-11-30 10:43:00 UTC 
Created attachment 150021 [details]
Build log
Comment 3 Bernard Spil freebsd_committer freebsd_triage 2014-11-30 10:46:13 UTC 
Created attachment 150023 [details]
Patch for Makefile

Tested, and works!

# /usr/local/bin/sa-learn --no-sync --spam -u mailnull /home/spam/.Spam/cur
Learned tokens from 0 message(s) (0 message(s) examined)
# /usr/local/bin/sa-learn --force-expire
#
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-11-30 21:27:12 UTC 
A commit references this bug:

Author: adamw
Date: Sun Nov 30 21:26:37 UTC 2014
New revision: 373689
URL: https://svnweb.freebsd.org/changeset/ports/373689

Log:
  Add a patch from SA bug #7107, to quiet warnings due to bad usage of $^V
  that show up during sa-learn, sa-compile, etc.

  Note that other warnings can still show up, ex.:
  zoom: rule __FOR_SALE_PRC_100K will loop on SpamAssassin older than 3.3.2 running under Perl 5.12 or older, Bug 6558

  While here, go with the @dir new world order. SA is not poudriere clean at this time;
  /var/spool/spamd is the homedir of user spamd, so I am pretty sure it shouldn't be
  listed with @dir. QA sees this as a leftover dir.

  PR:		195524
  Submitted by:	Bernard Spil

Changes:
  head/japanese/spamassassin/Makefile
  head/mail/spamassassin/Makefile
  head/mail/spamassassin/files/patch-bug7107
  head/mail/spamassassin/pkg-plist
Comment 5 Adam Weinberger freebsd_committer freebsd_triage 2014-11-30 21:28:17 UTC 
Committed. Thanks for doing the sleuthing here, Bernard. These warnings showed up during sa-compile too.

With the new perl updates, I am seeing other warnings popping up during sa-compile:

zoom: rule __FOR_SALE_PRC_100K will loop on SpamAssassin older than 3.3.2 running under Perl 5.12 or older, Bug 6558

You seeing that too?
Comment 6 Bernard Spil freebsd_committer freebsd_triage 2014-12-01 08:39:19 UTC 
Hi Adam,

Only using the 3.4.0 SA branch/port and perl 5.18 (which became the default perl5 last week) so I'm not noticing any 3.3 fall-out.

Thanks for picking this up, loads of sys-admins will be very happy that the massive number of cron mails this created have now been reduced :D

With kind regards,

Bernard