Bug 195576 - [PATCH] [revive port] ports-mgmt/pkg-plist: Update to v1.4
Summary: [PATCH] [revive port] ports-mgmt/pkg-plist: Update to v1.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-02 01:21 UTC by lightside
Modified: 2014-12-05 17:13 UTC (History)
2 users (show)

See Also:

Attachments
Proposed patch (since 372182 revision) (4.68 KB, patch)
2014-12-02 01:21 UTC, lightside 		no flags Details | Diff
Update pkg-plist to 1.4; this supersedes the previous patch (2.37 KB, text/plain)
2014-12-02 21:44 UTC, martin 		martin: maintainer-approval+
Details
Proposed patch (since 372182 revision) (2.24 KB, patch)
2014-12-02 23:32 UTC, lightside 		lightside: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2014-12-02 01:21:55 UTC 
Created attachment 150092 [details]
Proposed patch (since 372182 revision)

Patch to update ports-mgmt/pkg-plist port from 1.2 to 1.3 version.

Look following link for changes:
http://code.arp242.net/pkg-plist/compare/version_1.3..version_1.2

As stated in Makefile, this port was deprecated because of "Generate incorrect plists". I think, it was related to deprecated @dirrm for plist. I fixed it and added support for @dir in case of empty directory not in mtree and possibility to use ${STAGEDIR}${LOCALBASE} directory after regular make as a default prefix.
Comment 1 martin 2014-12-02 21:44:55 UTC 
Created attachment 150109 [details]
Update pkg-plist to 1.4; this supersedes the previous patch

Hi,

Thank you again for your patch.

I updated the code upstream, and released version 1.4; I've added a new patch which updates the port to 1.4.

Cheers,
Martin
Comment 2 lightside 2014-12-02 22:02:57 UTC 
Comment on attachment 150092 [details]
Proposed patch (since 372182 revision)

Hello Martin.

Thank you for your attention.
Comment 3 lightside 2014-12-02 23:32:09 UTC 
Created attachment 150110 [details]
Proposed patch (since 372182 revision)

I adapted MASTER_SITES and WRKSRC to method, which is used on GitHub, but also possible to use on Bitbucket. This removes the need for downloading to DIST_SUBDIR sub directory.
Also I changed pkg-descr file a bit, because of UTF-8 encoding.
Comment 4 martin 2014-12-03 12:57:08 UTC 
Okay sure, looks good :-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-12-05 17:13:19 UTC 
A commit references this bug:

Author: amdmi3
Date: Fri Dec  5 17:13:05 UTC 2014
New revision: 374060
URL: https://svnweb.freebsd.org/changeset/ports/374060

Log:
  - Resurrect ports-mgmt/pkg-plist, update to 1.4

  Make a pkg-plist for a FreeBSD port. Try to be as "automatic" as possible.

  That's all it does ;-)

  Basic usage
  ===========
  1. Build your port to the staging directory: `make stage`.
  2. Run this from your port's directory (or set `-p`).

  Alternatively, you can install your ports to a "fake" prefix, this is the "old"
  from before staging support, but it has the added advantage that you've tested
  whether your port works when installing to a different prefix.

  1. Build & install your port with a different `PREFIX`: `make install
     PREFIX=/var/tmp/ptest`.
  2. Run this from your port's directory with `-x` set to `PREFIX`.

  WWW: http://code.arp242.net/pkg-plist

  PR:		195576
  Submitted by:	lightside@gmx.com
  Approved by:	martin@arp242.net (maintainer)

Changes:
  head/ports-mgmt/Makefile
  head/ports-mgmt/pkg-plist/
  head/ports-mgmt/pkg-plist/Makefile
  head/ports-mgmt/pkg-plist/distinfo
  head/ports-mgmt/pkg-plist/pkg-descr