Bug 195689 - [patch] sysutils/munin-node: plugin bind9_rndc stats change order every update with Perl 5.18
Summary: [patch] sysutils/munin-node: plugin bind9_rndc stats change order every updat...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-04 21:37 UTC by VK
Modified: 2014-12-10 15:56 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mat)

Attachments
bind9_rndc.patch (1.60 KB, patch)
2014-12-04 21:37 UTC, VK 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description VK freebsd_triage 2014-12-04 21:37:02 UTC 
Created attachment 150200 [details]
bind9_rndc.patch

With the Perl upgrade to 5.18, in 5.18 the hash ordering is random which is now randomizing the order of graph elements for bind9_rndc plugin of sysutils/munin-node. At the very least, this is inconvenient and annoying as every update pass results with differently colored values which is inconsistent between daily, weekly and monthly graphs as they update at different times.

Attached is a proposed patch to fix this by predefining the graph elements in an array and using that for a fixed order.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-04 21:37:02 UTC 
Auto-assigned to maintainer mat@FreeBSD.org
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-12-10 15:52:34 UTC 
A commit references this bug:

Author: mat
Date: Wed Dec 10 15:52:18 UTC 2014
New revision: 374474
URL: https://svnweb.freebsd.org/changeset/ports/374474

Log:
  Fix the bind9_rndc plugin wrt Perl 5.18+ hash randomzation.

  While there, group all patches for the three ports in munin-common, and remove
  an obsolete patch.

  PR:		195689
  Submitted by:	Vlad "Blackflow" K.
  Sponsored by:	Absolight

Changes:
  head/sysutils/munin-common/files/patch-node_munin-node.conf.in
  head/sysutils/munin-common/files/patch-node_sbin_munin-node
  head/sysutils/munin-common/files/patch-node_sbin_munin-node-configure
  head/sysutils/munin-common/files/patch-node_sbin_munin-run
  head/sysutils/munin-common/files/patch-plugins_node.d.freebsd_if__.in
  head/sysutils/munin-common/files/patch-plugins_node.d.freebsd_if__errcoll__.in
  head/sysutils/munin-common/files/patch-plugins_node.d.freebsd_if__packets__.in
  head/sysutils/munin-common/files/patch-plugins_node.d.freebsd_iostat.in
  head/sysutils/munin-common/files/patch-plugins_node.d_bind9__rndc.in
  head/sysutils/munin-common/files/patch-plugins_node.d_hddtemp__smartctl.in
  head/sysutils/munin-common/files/patch-plugins_node.d_multiping.in
  head/sysutils/munin-common/files/patch-plugins_node.d_nutups__.in
  head/sysutils/munin-common/files/patch-plugins_node.d_squeezebox__.in
  head/sysutils/munin-common/munin.mk
  head/sysutils/munin-node/Makefile
  head/sysutils/munin-node/files/patch-node__munin-node.conf.in
  head/sysutils/munin-node/files/patch-node__sbin__munin-node
  head/sysutils/munin-node/files/patch-node__sbin__munin-node-configure
  head/sysutils/munin-node/files/patch-node__sbin__munin-run
  head/sysutils/munin-node/files/patch-ntp_offset.in
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__if_.in
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__if_errcoll_.in
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__if_packets_.in
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__iostat.in
  head/sysutils/munin-node/files/patch-plugins__node.d__hddtemp_smartctl.in
  head/sysutils/munin-node/files/patch-plugins__node.d__multiping.in
  head/sysutils/munin-node/files/patch-plugins__node.d__squeezebox_.in
  head/sysutils/munin-node/files/patch-plugins_node.d_nutups__.in