Bug 195715 - [patch] net/torsocks - upgrade to 2.0
Summary: [patch] net/torsocks - upgrade to 2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2014-12-05 16:07 UTC by Beeblebrox
Modified: 2015-03-29 19:58 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (andy.lavr)


Attachments
Patch to update to 2.0.0 (14.92 KB, patch)
2015-03-24 23:39 UTC, Yuri Victorovich
no flags Details | Diff
poudriere log (40.08 KB, text/plain)
2015-03-24 23:40 UTC, Yuri Victorovich
no flags Details
Patch to update to 2.0.0 (15.50 KB, patch)
2015-03-29 19:21 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beeblebrox 2014-12-05 16:07:14 UTC
net/torsocks gives "authentication failure" and password error.

Example:
$ torsocks wget www.ipmango.com/api/myip
Resolving www.ipmango.com (www.ipmango.com)... 173.255.230.5 \ Connecting to www.ipmango.com (www.ipmango.com)|173.255.230.5|:80... 17:47:01 libtorsocks(28774): Need a password in torsocks.conf or $TORSOCKS_PASSWORD to authenticate withfailed: Connection refused.

This is a documented problem: https://trac.torproject.org/projects/tor/ticket/9695

The solution is to upgrade to torsocks 2.0, where #9695 is fixed
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-05 16:07:14 UTC
Maintainer CC'd
Comment 2 John Marino freebsd_committer freebsd_triage 2015-01-22 10:37:21 UTC
If you had provided a patch, we could have applied it to the port without maintainer approval since he never responded.  Without a patch, we can't do much when a maintainer doesn't respond.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2015-03-24 10:01:45 UTC
I think this is the case of unresponsive maintainer.
He didn't reply beginning Nov 2013. In 2013 1.3 version was released, and last year 2.0 was released, and package is still @1.2.

John, do you think you should update MAINTAINER=ports@ ? Otherwise every action will be on hold.
Comment 4 John Marino freebsd_committer freebsd_triage 2015-03-24 10:23:56 UTC
yes.
The maintainer didn't stage the port, somebody else did.  If that had not happened, the maintainer would have been reset then.  So we can consider that serious non-responsiveness at that time.

Go ahead and make your patch either reset the maintainership, or better: assign yourself as maintainer.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2015-03-24 10:30:16 UTC
Ok, I will make a patch in a day.
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2015-03-24 23:39:58 UTC
Created attachment 154781 [details]
Patch to update to 2.0.0

This is patch-ready.

Please note that all old patches from net/torsocks/files/ are deleted, only two files there now:
> # ls net/torsocks/files/
> patch-compatibility-2.0.0 pkg-message.in

patch-compatibility-2.0.0 is submitted upstream.
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2015-03-24 23:40:46 UTC
Created attachment 154782 [details]
poudriere log
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2015-03-25 00:06:53 UTC
Also there is CAVEAT that firefox crashes with torsocks.
And chrome and opera seem to be much more sluggish for some reason, compared to when Tor is accessed through SOCK5 directly.
Comment 9 John Marino freebsd_committer freebsd_triage 2015-03-27 15:39:56 UTC
looks decent, I'm promoting the PR.
Comment 10 Yuri Victorovich freebsd_committer freebsd_triage 2015-03-27 23:08:37 UTC
The caveat I mentioned is due to the fact that torsocks fails socket(2) for UDP protocol, instead of just "losing" packets, what usually happens. Many apps, including firefox and qTox, fail to process such socket(2) error code, and crash. So this isn't a bug in torsocks, rather in the other apps due to this somewhat unique situation.
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2015-03-29 14:19:11 UTC
Build tests worked on 10.1a, 9.3a, failed on 8.4i.

See http://people.freebsd.org/~pi/logs/net__torsocks*

(some github-related fixes were necessary)
Comment 12 Kurt Jaeger freebsd_committer freebsd_triage 2015-03-29 14:21:20 UTC
build works on 8.4a. Is this a i386 thing ?
Comment 13 Kurt Jaeger freebsd_committer freebsd_triage 2015-03-29 14:40:22 UTC
fails on 10.1i as well, so looks like i386 thing ?

http://people.freebsd.org/~pi/logs/net__torsocks-10i
Comment 14 Kurt Jaeger freebsd_committer freebsd_triage 2015-03-29 15:10:35 UTC
Should we add

ONLY_FOR_ARCHS= amd64

and commit now and investigate later ?

Yuri, please ACK.
Comment 15 Yuri Victorovich freebsd_committer freebsd_triage 2015-03-29 19:21:13 UTC
Created attachment 154970 [details]
Patch to update to 2.0.0

This was a bug in upstream code. I added the patch that should eliminate i386/amd64 build difference.

amd64 poudriere build passes fine.
And I don't have i386 environment here to verify.
Comment 16 John Marino freebsd_committer freebsd_triage 2015-03-29 19:36:52 UTC
(In reply to yuri from comment #15)
> amd64 poudriere build passes fine.
> And I don't have i386 environment here to verify.

If you have amd64 poudriere, why not just use it to make an i386 jail?
With amd64, you can test i386, but not vice-versa.
Comment 17 commit-hook freebsd_committer freebsd_triage 2015-03-29 19:56:31 UTC
A commit references this bug:

Author: pi
Date: Sun Mar 29 19:56:13 UTC 2015
New revision: 382623
URL: https://svnweb.freebsd.org/changeset/ports/382623

Log:
  net/torsocks: 1.2 -> 2.0.0

  - Changes:
    https://github.com/dgoulet/torsocks/blob/master/ChangeLog
  - Submitter takes maintainership
  - Repository moved from google to github (and further)

  PR:		195715
  Submitted by:	yuri@rawbw.com
  Approved by:	<andy.lavr@gmail.com> (maintainer timeout)

Changes:
  head/net/torsocks/Makefile
  head/net/torsocks/distinfo
  head/net/torsocks/files/patch-Makefile.am
  head/net/torsocks/files/patch-Makefile.in
  head/net/torsocks/files/patch-compatibility-2.0.0
  head/net/torsocks/files/patch-configure.in
  head/net/torsocks/files/patch-doc_Makefile.am
  head/net/torsocks/files/patch-src_Makefile.am
  head/net/torsocks/files/patch-src_Makefile.in
  head/net/torsocks/files/patch-src_torsocks.in
  head/net/torsocks/files/patch-src_usewithtor.in
  head/net/torsocks/files/patch-tests_Makefile.am
  head/net/torsocks/files/pkg-message.in
  head/net/torsocks/pkg-descr
  head/net/torsocks/pkg-plist
Comment 18 Kurt Jaeger freebsd_committer freebsd_triage 2015-03-29 19:57:58 UTC
Tests with i386 on 10.1, 8.4 went fine.

Committed, thanks!

Please note that I changed pkg-descr with WWW: to github, but the
final repo is now

https://gitweb.torproject.org/torsocks.git