Bug 196156 - [PATCH]: Fix comms/owfs on FreeBSD 8.x & 9.x
Summary: [PATCH]: Fix comms/owfs on FreeBSD 8.x & 9.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-20 13:59 UTC by Johan Ström
Modified: 2014-12-22 18:42 UTC (History)
1 user (show)

See Also:

Attachments
Makefile + pkg-plist patch (3.32 KB, patch)
2014-12-20 13:59 UTC, Johan Ström 		no flags Details | Diff
testport output for 8.4 amd64 (549.10 KB, text/plain)
2014-12-20 13:59 UTC, Johan Ström 		no flags Details
testport output for 10.0 amd64 (39.58 KB, text/plain)
2014-12-20 14:01 UTC, Johan Ström 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Ström 2014-12-20 13:59:34 UTC 
Created attachment 150803 [details]
Makefile + pkg-plist patch

comms/owfs does not build on FreeBSD 8.x or 9.x due to non-portable Makefile issues (see http://beefy2.isc.freebsd.org/data/84amd64-default/2014-12-18_17h11m07s/logs/owfs-2.9p8_1.log).

In addition, it was noted that it doesn't build man-pages *properly* on FreeBSD 10, full man-pages wasn't installed.

This patch changes to gmake on all FreeBSD versions, which allows us to build properly on all versions.


Also marking OWPERL option as BROKEN, since the previous ports perl-changes, the build fails with the following error, if OWPERL is enabled:

====> Running Q/A tests (stage-qa)
Warning: /wrkdirs/usr/ports/comms/owfs/work/stage/usr/local/lib/perl5/site_perl/mach/5.18/auto/OW/OW.so is not linked with libperl.so.5.18, not respecting lddlflags?
Error: None of the .so in /wrkdirs/usr/ports/comms/owfs/work/stage/usr/local/lib/perl5/site_perl/mach/5.18 are linked with libperl.so.5.18, see above for the full list.



Attached is test, and successful build logs on 84amd64 and 100amd64.
Comment 1 Johan Ström 2014-12-20 13:59:57 UTC 
Created attachment 150804 [details]
testport output for 8.4 amd64
Comment 2 Johan Ström 2014-12-20 14:01:20 UTC 
Created attachment 150805 [details]
testport output for 10.0 amd64

build output stripped due to file size limitation on attachment
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-12-22 18:38:17 UTC 
A commit references this bug:

Author: pawel
Date: Mon Dec 22 18:37:58 UTC 2014
New revision: 375258
URL: https://svnweb.freebsd.org/changeset/ports/375258

Log:
  Fix build on FreeBSD 8.x and 9.x by using gmake

  PR:		196156
  Submitted by:	maintainer

Changes:
  head/comms/owfs/Makefile
  head/comms/owfs/Makefile.options
  head/comms/owfs/pkg-plist