Bug 196157 - devel/qt4-script: fix build in mips
Summary: devel/qt4-script: fix build in mips
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: mips Any
: --- Affects Some People
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-20 14:08 UTC by Dmitry Marakasov
Modified: 2014-12-24 02:51 UTC (History)
0 users

See Also:
rakuco: maintainer-feedback+


Attachments
Patch (808 bytes, patch)
2014-12-20 14:08 UTC, Dmitry Marakasov
no flags Details | Diff
Error log (113.84 KB, text/plain)
2014-12-20 14:08 UTC, Dmitry Marakasov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-20 14:08:18 UTC
Created attachment 150806 [details]
Patch

qt4-script fails on mips complaining on missing include:

../3rdparty/javascriptcore/JavaScriptCore/wtf/Platform.h:339:21: error: sgidefs.h: No such file or directory

(full log attached)

That header seems to be linux-specific and it anyway just contains legacy defines not used by qt anyway, so removing the mentioned #include it fixes the build.

Related upstream issue:

https://bugreports.qt-project.org/browse/QTBUG-43486
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-20 14:08:18 UTC
Auto-assigned to maintainer kde@FreeBSD.org
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-20 14:08:47 UTC
Created attachment 150807 [details]
Error log
Comment 3 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-12-23 23:12:10 UTC
Approved, thanks. Please include at least the lines saying the header was not found from the error log in your commit message. Bonus points if you also submit this upstream :-)
Comment 4 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-12-23 23:16:37 UTC
BTW, doesn't this also apply to devel/qt5-script?
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-12-24 02:47:42 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Dec 24 02:47:34 UTC 2014
New revision: 375385
URL: https://svnweb.freebsd.org/changeset/ports/375385

Log:
  - Fix build on MIPS by remiving non-existent, unused include

  Upstream issue: https://bugreports.qt-project.org/browse/QTBUG-43486

  PR:		196157
  Submitted by:	amdmi3
  Approved by:	rakuco

Changes:
  head/devel/qt4-script/files/patch-src__3rdparty__javascriptcore__JavaScriptCore__wtf__Platform.h
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-24 02:51:38 UTC
> Bonus points if you also submit this upstream :-)

As mentioned in the PR, I've opened an issue in upstream tracker.

> BTW, doesn't this also apply to devel/qt5-script?

Unknown. qt5-qmake doesn't build on mips, so I can't test qt5-script yet.