Bug 196374 - devel/cmake: OPTIONS menu shows up every time (pre.mk before OPTIONS)
Summary: devel/cmake: OPTIONS menu shows up every time (pre.mk before OPTIONS)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Some People
Assignee: freebsd-kde (group)
URL:
Keywords: easy, patch, patch-ready, regression
Depends on:
Blocks:
 
Reported: 2014-12-30 08:18 UTC by Tomoaki AOKI
Modified: 2014-12-30 09:56 UTC (History)
0 users

See Also:
rakuco: maintainer-feedback+

Attachments
Patch for Makefile to fix. apply in devel/cmake directory. (792 bytes, patch)
2014-12-30 08:18 UTC, Tomoaki AOKI 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomoaki AOKI 2014-12-30 08:18:59 UTC 
Created attachment 151104 [details]
Patch for Makefile to fix. apply in devel/cmake directory.

OPTIONS menu shows up every time devel/cmake is processed.
bsd.ports.pre.mk should NOT be included before OPTIONS items.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-30 08:18:59 UTC 
Auto-assigned to maintainer kde@FreeBSD.org
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-12-30 09:49:01 UTC 
Looks good, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-12-30 09:51:49 UTC 
A commit references this bug:

Author: rakuco
Date: Tue Dec 30 09:51:00 UTC 2014
New revision: 375826
URL: https://svnweb.freebsd.org/changeset/ports/375826

Log:
  Include bsd.port.pre.mk after setting OPTIONS.

  r375798 made the OPTIONS prompt show up on every build because
  bsd.port.pre.mk was being included too early. Move the inclusion down one
  section.

  PR:		196374
  Submitted by:	Tomoaki AOKI <junchoon@dec.sakura.ne.jp>

Changes:
  head/devel/cmake/Makefile