Created attachment 151212 [details] graphics/zathura The update brings some bug fixes. Additionally, the port provides a patch for crashing on search. The problem that still persists is one has to type slowly in command line otherwise not all letters appear.
Maintainer CC'd
Created attachment 151213 [details] graphics/zathura-cb
Created attachment 151214 [details] graphics/zathura-djvu
Created attachment 151215 [details] graphics/zathura-ps
Thanks for your submission Mike. It appears there are two new ports (zathura-cb & zathura-ps) in the attachment list. Additionally: Can you: - Split those 2 out into their own issue reports please - Clarify MAINTAINER email as it does not match your issue tracker email
Also, graphics/zathura-djvu needs approval from a different maintainer. Let's see how this 'multiple ports, multiple maintainers, multiple different updates' thing goes. If it gets too complex here, we'll need to split it out as well. In this issue, for zathura and zathura-djvu, please attach: - portlint -AC output (after fixing any issues) - Successful poudriere output, OR - make stage && make check-plist && make stage-qa && make package output Please do the same for the new issues you create for zathura-cb and zathura-ps
If it's possible I want reject maintaining of zathura-cb and zathura-ps. I don't use ComicBooks and PostScript files (only pdf files) so I can't test them. @mike.d.ft402: do you use ComicBooks/PostScript? Do you will use zathura-{cb,ps}? If yes, I think you can be their maintainer.
Created attachment 151243 [details] graphics/zathura
Created attachment 151244 [details] graphics/zathura: portlint output
Created attachment 151245 [details] graphics/zathura: poudirere output
Created attachment 151246 [details] graphics/zathura-djvu
Created attachment 151247 [details] graphics/zathura-djvu: portlint output
Created attachment 151248 [details] graphics/zathura-djvu: poudriere output
Created attachment 151249 [details] graphics/zathura-pdf-mupdf
Created attachment 151250 [details] graphics/zathura-pdf-mupdf: portlint output
Created attachment 151251 [details] graphics/zathura-pdf-mupdf: poudriere output
Created attachment 151252 [details] graphics/zathura-pdf-poppler
Created attachment 151253 [details] graphics/zathura-pdf-poppler: portlint output
Created attachment 151254 [details] graphics/zathura-pdf-poppler: poudriere output
(In reply to Zsolt Udvari from comment #7) Despite only seriously using -ps, I can take care of both. (In reply to Kubilay Kocak from comment #6) Done! Also rectified -pdf* ones.
(In reply to mike.d.ft402 from comment #14) (In reply to mike.d.ft402 from comment #17) Why do you want to change PORTNAME zathura-pdf-* and introduce PKGNAMESUFFIX? These ports are plugins not another versions/different build of zathura!
(In reply to Zsolt Udvari from comment #21) Thought that would be more consistent. I remember portlint not liking "-" in port names, but now it says nothing if I leave port names. Going to undo it now.
(In reply to mike.d.ft402 from comment #22) PORTVERSION shouldn't contains "-". Check Porter's Handbook! https://www.freebsd.org/doc/en/books/porters-handbook/
(In reply to Zsolt Udvari from comment #23) Names not versions.
(In reply to mike.d.ft402 from comment #24) I want to say that PORTNAME can contain "-" and PORTVERSION doesn't contain "-". https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html "The version string ... is a period-separated list of integers and single lowercase alphabetics. In particular, it is not permissible to have another dash inside the version string." You can check it with portlint too. I think you've confused dash-valid PORTNAME and dash-invalid PORTVERSION :)
(In reply to Zsolt Udvari from comment #25) It was quite some time ago, so probably yes. Putting corrections in a second.
Created attachment 151264 [details] graphics/zathura
Created attachment 151265 [details] graphics/zathura: portlint
Created attachment 151266 [details] graphics/zathura: poudirere
Created attachment 151267 [details] graphics/zathura-djvu
Created attachment 151268 [details] graphics/zathura-djvu: portlint
Created attachment 151269 [details] graphics/zathura-djvu: poudriere
Created attachment 151270 [details] graphics/zathura-pdf-mupdf
Created attachment 151271 [details] graphics/zathura-pdf-mupdf: portlint
Created attachment 151272 [details] graphics/zathura-pdf-mupdf: poudriere
Created attachment 151273 [details] graphics/zathura-pdf-poppler
Created attachment 151274 [details] graphics/zathura-pdf-poppler: portlint
Created attachment 151275 [details] graphics/zathura-pdf-poppler: poudriere
(In reply to mike.d.ft402 from comment #33) Please don't put content of pkg-plist into Makefile! "Usage of PLIST_FILES should not be abused. When looking for the origin of a file, people usually try to grep through the pkg-plist files in the ports tree. Listing files in PLIST_FILES in the Makefile makes that search more difficult."
(In reply to Zsolt Udvari from comment #39) While porting another port with just a couple files, I was told to use PLIST_FILES. "pkg which" should be able to deal with it no problem?
'pkg which' works only with installed packages. If you've a script and prints 'foo: Command not found' you should find which port contains bin/foo: find /usr/ports -name pkg-plist | xargs grep bin/foo I don't see any benefit deal with PLIST_FILES.
(In reply to Zsolt Udvari from comment #41) In the future, not all users will even have ports tree -- I am sure there will be a way to do it through pkg. As for the way it is done in the ports you maintain, you are free to alter the ones I suggested to your liking and submit the changes.
(In reply to mike.d.ft402 from comment #42) Yes, in the future. But we are in present :) But once again: I don't see any benefit PLIST_FILES. Or do you? But pkg-plist has many benefit. And I think you misunderstood one thing: I'm "only" maintainer of some ports (including zathura-pdf-mupdf) but I don't have write access to ports tree, I can't submit any change.
(In reply to Zsolt Udvari from comment #43) This or that, pkglint told me to use PKG_PLIST. You can attach your changes here -- committers will consider them.
I don't have any suggestion about zathura-pdf-mupdf. Maybe should rebuild after zathura's update (upgrade PORTREVISION).
Sorry for long delay, zathura-djvu diff file seems to be ok.
Created attachment 151954 [details] graphics/zathura
Created attachment 151955 [details] graphics/zathura: Portlint
Created attachment 151956 [details] graphics/zathura: Poudriere
Created attachment 151957 [details] graphics/zathura-djvu
Created attachment 151958 [details] graphics/zathura-djvu: Portlint
Created attachment 151959 [details] graphics/zathura-djvu: Poudriere
Created attachment 151960 [details] graphics/zathura-pdf-mupdf
Created attachment 151961 [details] graphics/zathura-pdf-mupdf: Portlint
Created attachment 151962 [details] graphics/zathura-pdf-mupdf: Poudriere
Created attachment 151963 [details] graphics/zathura-pdf-poppler
Created attachment 151964 [details] graphics/zathura-pdf-poppler: Portlint
Created attachment 151965 [details] graphics/zathura-pdf-poppler: Poudriere
(My previous update seems to have been lost during a Bugzilla maintenance). I agree with the patch for zathura.
Corrected mupdf SSL linkage and PWMT license name.
Created attachment 152303 [details] zathura The zathura port update needed a few fixes to work on all supported FreeBSD versions: - new version tries to pass -fdiagnostics-color=always to the compiler, but gcc on older releases does not digest that. I simply removed the option. - Had to patch the Makefile, there's a mistake which makes building with WITH_SQLITE=0 (the default) impossible. Regarding this plase note that on a default installation gtk3 depends on colord which will pull in sqlite anyway, so I'd like to make the SQLITE option a default. While not blocking, I added ZLIB_INC and ZLIB_LIB variables to MAKE_ENV. This clears a lot of warnings on all supported releases (except head). zlib is included in base, but, except on recent head, there's not zlib.pc pkgconfig file, and without this change the build generates many warnings about this. I also simplified the Makefile a little by taking advantage of option helpers. For other ports I just tweaked COMMENT a little and bumped portrevisions. (patches following) A further note to the submitter: Reading your poudriere logs I see you are testing with many custom knobs. While it is good to also test non default options configurations, what is also very important is for the default options setup to work. There is no written rule about this, but if you provide poudriere build logs I'd suggest you send ones done with no custom options set. Can you review these patches and approve them, if you see fit? Thanks.
Created attachment 152304 [details] zathura-djvu
Created attachment 152305 [details] zathura-mupdf
Created attachment 152306 [details] zathura-pdf-poppler
I approve zathura-pdf-mupdf.
I approve the latest patch for the zathura port.
Comment on attachment 152305 [details] zathura-mupdf Maintainer approved this patch.
Comment on attachment 152303 [details] zathura Maintainer approved this patch.
Approve
Comment on attachment 152304 [details] zathura-djvu Maintainer approved.
Committed. Thanks!
A commit references this bug: Author: madpilot Date: Sun Feb 1 21:41:01 UTC 2015 New revision: 378276 URL: https://svnweb.freebsd.org/changeset/ports/378276 Log: - Update graphics/zathura to 0.3.2 [1] - Update graphics/zathura-djvu to 0.2.4 [2] - Fix OpenSSL library path in graphics/zathura-pdf-mupdf [3] - Use OPTION Helpers [1] - Add LICENSE [1] [2] [3] PR: 196438 Submitted by: mike.d.ft402@gmail.com Approved by: quentin.stievenart@gmail.com (maintainer of zathura) [1] Approved by: alexander.4mail@gmail.com (maintainer of zathura-djvu) [2] Approved by: Zsolt Udvari <udvzsolt@gmail.com> (maintainer of zathura-pdf-mupdf) [3] Changes: head/graphics/zathura/Makefile head/graphics/zathura/distinfo head/graphics/zathura/files/ head/graphics/zathura/files/patch-Makefile head/graphics/zathura/files/patch-zathura_page-widget.c head/graphics/zathura/files/patch-zathura_shortcuts.c head/graphics/zathura/pkg-plist head/graphics/zathura-djvu/Makefile head/graphics/zathura-djvu/distinfo head/graphics/zathura-pdf-mupdf/Makefile head/graphics/zathura-pdf-mupdf/pkg-plist head/graphics/zathura-pdf-poppler/Makefile