Bug 196970 - cad/pcb is x86 only, future proof the Makefile and explicitly declare it for i386/amd64 only
Summary: cad/pcb is x86 only, future proof the Makefile and explicitly declare it for ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Hiroki Sato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-21 16:15 UTC by Sean Bruno
Modified: 2015-02-09 15:36 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (hrs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer freebsd_triage 2015-01-21 16:15:51 UTC
Build failed on ARM and it was noted that this port has been marked as broken on non-x86 architectures, but not updated for ARM.  

Instead of extending the .for loop, explicitly declare it only for i386/amd64:

Index: /usr/local/poudriere/ports/11-armv6-ports/cad/pcb/Makefile
===================================================================
--- /usr/local/poudriere/ports/11-armv6-ports/cad/pcb/Makefile  (revision 377338)
+++ /usr/local/poudriere/ports/11-armv6-ports/cad/pcb/Makefile  (working copy)
@@ -60,9 +60,8 @@
 NONE_CONFIGURE_ON=     --without-gui
 NONE_CONFIGURE_ENV=    WISH=/usr/bin/true
 
-.for a in ia64 powerpc sparc64
-BROKEN_${a}=   Does not compile on ia64, powerpc, or sparc64
-.endfor
+ONLY_FOR_ARCHS=                i386 amd64
+ONLY_FOR_ARCHS_REASON=    Uses x86 assembly and has not been ported
 
 .include <bsd.port.options.mk>
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-21 16:15:51 UTC
Auto-assigned to maintainer hrs@FreeBSD.org
Comment 2 Sean Bruno freebsd_committer freebsd_triage 2015-01-21 16:16:54 UTC
Actually, this is more accurate:

Index: /usr/local/poudriere/ports/11-armv6-ports/cad/pcb/Makefile
===================================================================
--- /usr/local/poudriere/ports/11-armv6-ports/cad/pcb/Makefile  (revision 377338)
+++ /usr/local/poudriere/ports/11-armv6-ports/cad/pcb/Makefile  (working copy)
@@ -60,9 +60,8 @@
 NONE_CONFIGURE_ON=     --without-gui
 NONE_CONFIGURE_ENV=    WISH=/usr/bin/true
 
-.for a in ia64 powerpc sparc64
-BROKEN_${a}=   Does not compile on ia64, powerpc, or sparc64
-.endfor
+ONLY_FOR_ARCHS=                i386 amd64
+ONLY_FOR_ARCHS_REASON=    Uses x86 specific libc functions and has not been ported
 
 .include <bsd.port.options.mk>
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-02-09 15:34:44 UTC
A commit references this bug:

Author: sbruno
Date: Mon Feb  9 15:33:55 UTC 2015
New revision: 378737
URL: https://svnweb.freebsd.org/changeset/ports/378737

Log:
  Reverse the logic of architecture support.

  Add a list of support architectures with a REASON that these are the only
  supported targets. This will now skip this port on mips/mips64/armv6.

  PR:		196970
  Differential Revision:	196970
  Reviewed by:	hrs (in irc)
  Approved by:	mentor (implicit)

Changes:
  head/cad/pcb/Makefile