Bug 197147 - security/keepassx2: plist incomplete
Summary: security/keepassx2: plist incomplete
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-01-28 01:40 UTC by Dmitry Marakasov
Modified: 2015-01-29 02:17 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+

Attachments
Patch (6.25 KB, patch)
2015-01-28 01:40 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-01-28 01:40:46 UTC 
Created attachment 152289 [details]
Patch

Plist is missing bunch of files, see attached patch. While here, drop @dirrm* from plist and add empty dirs
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-28 01:40:46 UTC 
Maintainer CC'd
Comment 2 Eric Camachat 2015-01-28 02:25:47 UTC 
Hmm... my build doesn't have that files, see below, could you provide your build log?

# find /usr/local/share -name '*keepassx*' -type f
/usr/local/share/icons/hicolor/16x16/apps/keepassx.png
/usr/local/share/icons/hicolor/24x24/apps/keepassx.png
/usr/local/share/icons/hicolor/32x32/apps/keepassx.png
/usr/local/share/icons/hicolor/48x48/apps/keepassx.png
/usr/local/share/icons/hicolor/64x64/apps/keepassx.png
/usr/local/share/icons/hicolor/128x128/apps/keepassx.png
/usr/local/share/icons/hicolor/256x256/apps/keepassx.png
/usr/local/share/icons/hicolor/scalable/apps/keepassx.svgz
/usr/local/share/icons/matefaenzagray/status/24/keepassx-panel.png
/usr/local/share/icons/matefaenzagray/status/22/keepassx-panel.png
/usr/local/share/icons/matefaenzagray/extras/keepassx/icons/keepassx.png
/usr/local/share/icons/matefaenzadark/status/24/keepassx-panel.png
/usr/local/share/icons/matefaenzadark/status/22/keepassx-panel.png
/usr/local/share/icons/matefaenzadark/extras/keepassx/icons/keepassx.png
/usr/local/share/icons/matefaenza/status/24/keepassx-panel.png
/usr/local/share/icons/matefaenza/status/22/keepassx-panel.png
/usr/local/share/icons/matefaenza/extras/keepassx/icons/keepassx.png
/usr/local/share/icons/matefaenza/apps/scalable/keepassx.svg
/usr/local/share/icons/matefaenza/apps/96/keepassx.png
/usr/local/share/icons/matefaenza/apps/64/keepassx.png
/usr/local/share/icons/matefaenza/apps/48/keepassx.png
/usr/local/share/icons/matefaenza/apps/32/keepassx.png
/usr/local/share/icons/matefaenza/apps/24/keepassx.png
/usr/local/share/icons/matefaenza/apps/22/keepassx.png
/usr/local/share/icons/matefaenza/apps/16/keepassx.png
/usr/local/share/keepassx/icons/application/128x128/apps/keepassx.png
/usr/local/share/keepassx/icons/application/16x16/apps/keepassx.png
/usr/local/share/keepassx/icons/application/24x24/apps/keepassx.png
/usr/local/share/keepassx/icons/application/256x256/apps/keepassx.png
/usr/local/share/keepassx/icons/application/32x32/apps/keepassx.png
/usr/local/share/keepassx/icons/application/48x48/apps/keepassx.png
/usr/local/share/keepassx/icons/application/64x64/apps/keepassx.png
/usr/local/share/keepassx/icons/application/scalable/apps/keepassx.svgz
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-01-28 05:26:17 UTC 
Submitter is committer
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2015-01-28 21:42:02 UTC 
Obviously you won't have them in /usr/local because they need to be listed in pkg-plist to be included into package. You could've look into ${STAGEDIR} instead.

https://people.freebsd.org/~amdmi3/keepassx2.log
Comment 5 Eric Camachat 2015-01-28 21:53:39 UTC 
Your're right, Dmitry please commit it.
Thanks.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-01-29 02:17:54 UTC 
A commit references this bug:

Author: amdmi3
Date: Thu Jan 29 02:17:31 UTC 2015
New revision: 378100
URL: https://svnweb.freebsd.org/changeset/ports/378100

Log:
  - Add missing plist files and empty dirs, drop @dirrm*

  PR:		197147
  Submitted by:	amdmi3
  Approved by:	eric@camachat.org (maintainer)

Changes:
  head/security/keepassx2/Makefile
  head/security/keepassx2/pkg-plist