Bug 197184 - x11/libxkbfile: fix build with clang 3.6.0
Summary: x11/libxkbfile: fix build with clang 3.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks: 197395
  Show dependency tree / graph
 
Reported: 2015-01-29 19:53 UTC by Dmitry Marakasov
Modified: 2015-02-07 15:59 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (x11)

Attachments
Patch (547 bytes, patch)
2015-01-29 19:53 UTC, Dmitry Marakasov 		no flags Details | Diff
Full build log (31.02 KB, text/plain)
2015-01-30 17:28 UTC, Dmitry Marakasov 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-01-29 19:53:37 UTC 
Created attachment 152348 [details]
Patch

I'm testing ports building on experimental projects/clang360-import branch, and libxkbfile fails there because of more strict warnings of clang 3.6:

---
===>  Building for libxkbfile-1.0.8_2
/usr/bin/make  all-recursive
Making all in src
  CC     cout.lo
cout.c:48:46: error: address of array 'xkb->names->vmods' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
    if ((!xkb)||(!xkb->names)||(!xkb->names->vmods))
                                ~~~~~~~~~~~~~^~~~~
1 error generated.
*** Error code 1
---

The vmods member is really an array, so the warning is valid. The fix is to remove the useless check. It was already fixed upstream:

http://cgit.freedesktop.org/xorg/lib/libxkbfile/commit/?id=9fa04388dcbb5bf205319569f540a62c03754688
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-29 19:53:37 UTC 
Auto-assigned to maintainer x11@FreeBSD.org
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-01-30 17:28:25 UTC 
Created attachment 152382 [details]
Full build log
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2015-01-30 17:32:00 UTC 
Oops, please disregard the log. It was for 197201
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-03 18:55:24 UTC 
A commit references this bug:

Author: kwm
Date: Tue Feb  3 18:54:28 UTC 2015
New revision: 378364
URL: https://svnweb.freebsd.org/changeset/ports/378364

Log:
  Add patch from upstream to fix the build with clang 3.6.

  PR:		197184
  Submitted by:	amdmi3@
  Obtained from:	libxkbfile upstream

Changes:
  head/x11/libxkbfile/files/
  head/x11/libxkbfile/files/patch-src_cout.c