Bug 197330 - devel/libcli: needs -Werror flag removed for DragonFly support
Summary: devel/libcli: needs -Werror flag removed for DragonFly support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-04 19:02 UTC by John Marino
Modified: 2015-02-18 08:52 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (tj)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer freebsd_triage 2015-02-04 19:02:46 UTC
on the libcli port, the Makefile was patched, specifically this line

-CFLAGS += $(DEBUG) $(OPTIM) -Wall -std=c99 -pedantic -Wformat-security -Wno-format-zero-length -Werror -Wwrite-strings -Wformat -fdiagnostics-show-option -Wextra -Wsign-compare -Wcast-align -Wno-unused-parameter
+CFLAGS += -Wall -Wformat-security -Wno-format-zero-length -Werror -Wwrite-strings -Wformat -fdiagnostics-show-option -Wextra -Wsign-compare -Wcast-align -Wno-unused-parameter


The "-Werror" flag should have been removed as well.  ON DragonFly:

cc  -pipe -O2 -fno-strict-aliasing -Wall -Wformat-security -Wno-format-zero-length -Werror -Wwrite-strings -Wformat -fdiagnostics-show-option -Wextra -Wsign-compare -Wcast-align -Wno-unused-parameter -fPIC -o clitest.o -c clitest.c
In file included from libcli.c:13:0:
/usr/include/malloc.h:2:2: error: #warning "this file includes <malloc.h> which is deprecated, use <stdlib.h> instead" [-Werror=cpp]
cc1: all warnings being treated as errors
Makefile:32: recipe for target 'libcli.o' failed


portmgr has issued a blanket to remove Werror as a rule (fyi) because in almost every cause the warning should not prevent the build from succeeding.

Can the patch be updated to remove -Werror too?
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-04 19:02:46 UTC
Auto-assigned to maintainer tj@FreeBSD.org
Comment 2 John Marino freebsd_committer freebsd_triage 2015-02-18 08:10:46 UTC
Simple as it is, the PR timed out.

I'll take it over and just do it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-02-18 08:52:03 UTC
A commit references this bug:

Author: marino
Date: Wed Feb 18 08:51:46 UTC 2015
New revision: 379202
URL: https://svnweb.freebsd.org/changeset/ports/379202

Log:
  devel/libcli: Disable -Werror to restore build on DragonFly

  This port includes <malloc.h> which generates a warning on DF.

  PR:		197330
  Submitted by:	marino@
  Approved by:	maintainer timeout (tj@)

Changes:
  head/devel/libcli/files/patch-Makefile