Bug 197768 - multimedia/plexmediaserver-plexpass: update to 0.9.11.12.869
Summary: multimedia/plexmediaserver-plexpass: update to 0.9.11.12.869
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mark Felder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-17 19:41 UTC by Ralf van der Enden
Modified: 2015-02-18 15:12 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (feld)

Attachments
patch to update the port to 0.9.11.12.869 (116.68 KB, patch)
2015-02-17 19:41 UTC, Ralf van der Enden 		no flags Details | Diff
build log (19.09 KB, text/plain)
2015-02-17 19:41 UTC, Ralf van der Enden 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf van der Enden 2015-02-17 19:41:20 UTC 
Created attachment 153116 [details]
patch to update the port to 0.9.11.12.869

Update to latest version.

Also modify the rc.d script so it cleans up remaining 'Plex Plug-in' and 'Plex DLNA Server' instances.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-17 19:41:20 UTC 
Auto-assigned to maintainer feld@FreeBSD.org
Comment 2 Ralf van der Enden 2015-02-17 19:41:42 UTC 
Created attachment 153117 [details]
build log
Comment 3 Mark Felder freebsd_committer freebsd_triage 2015-02-18 14:59:04 UTC 
I'm taking a different approach with the rc script. I've analyzed the child processes and they don't all have the same PPID as the main Plex process, but they have the same PGID. I can do something like this instead which is much cleaner:

plex_stop_precmd()
{
        if [ -r ${pidfile} ]; then
                export _PLEXPID=$(cat ${pidfile})
        fi
}

plex_stop_postcmd()
{
        _PLEX_CHILDREN=$(pgrep -g ${_PLEXPID})
        echo "Cleaning up leftover child processes."
        kill $sig_stop ${_PLEX_CHILDREN}
        wait_for_pids ${_PLEX_CHILDREN}
}
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-18 15:11:35 UTC 
A commit references this bug:

Author: feld
Date: Wed Feb 18 15:11:11 UTC 2015
New revision: 379209
URL: https://svnweb.freebsd.org/changeset/ports/379209

Log:
  Update to 0.9.11.12.869
  Teach the rc script to clean up children.

  PR:		197768

Changes:
  head/multimedia/plexmediaserver-plexpass/Makefile
  head/multimedia/plexmediaserver-plexpass/distinfo
  head/multimedia/plexmediaserver-plexpass/files/plexmediaserver_plexpass.in
  head/multimedia/plexmediaserver-plexpass/pkg-plist