Bug 197958 - [MAINTAINER] graphics/p5-Image-Scale: Fix BROKEN disable gif support
Summary: [MAINTAINER] graphics/p5-Image-Scale: Fix BROKEN disable gif support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bartek Rutkowski
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2015-02-23 17:41 UTC by atkin901
Modified: 2015-03-11 19:15 UTC (History)
1 user (show)

See Also:


Attachments
patch to disable gif support in p5-Image-Scale (1.47 KB, patch)
2015-02-23 17:41 UTC, atkin901
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description atkin901 2015-02-23 17:41:15 UTC
Created attachment 153378 [details]
patch to disable gif support in p5-Image-Scale

Unbreak graphics/p5-Image-Scale by disabling gif support.   Bugs have been entered into CPAN's tracker to fix upstream:

https://rt.cpan.org/Public/Bug/Display.html?id=101679
https://rt.cpan.org/Public/Bug/Display.html?id=101679
https://rt.cpan.org/Public/Bug/Display.html?id=101676

Since fixing gif support will require rewriting the entire gif code here that is beyond the scope of the port, so disable it here.
Comment 1 John Marino freebsd_committer freebsd_triage 2015-03-05 13:54:31 UTC
A test log would have been nice, but I'll promote without one since it alleges to unbreak the port.
Comment 2 atkin901 2015-03-05 14:35:39 UTC
Test Log:

[root@moby p5-Image-Scale]$ make clean
===>  Cleaning for p5-Image-Scale-0.08_6
[root@moby p5-Image-Scale]$ make test
===>  License GPLv2 accepted by the user
===>   p5-Image-Scale-0.08_6 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by p5-Image-Scale-0.08_6 for building
===>  Extracting for p5-Image-Scale-0.08_6
=> SHA256 Checksum OK for Image-Scale-0.08.tar.gz.
===>  Patching for p5-Image-Scale-0.08_6
===>  Applying FreeBSD patches for p5-Image-Scale-0.08_6
===>   p5-Image-Scale-0.08_6 depends on file: /usr/local/bin/perl5.18.4 - found
===>   p5-Image-Scale-0.08_6 depends on shared library: libjpeg.so - found (/usr/local/lib/libjpeg.so.8.4.0)
===>   p5-Image-Scale-0.08_6 depends on shared library: libpng.so - found (/usr/local/lib/libpng16.so)
===>  Configuring for p5-Image-Scale-0.08_6

Image::Scale will be built with:

  JPEG support:     yes (/usr/local/include, version 80)
  PNG support:      yes (/usr/local/include, version 1.6.16)
  GIF support:      no, install giflib or libungif

Checking if your kit is complete...
Looks good
Writing Makefile for Image::Scale
Writing MYMETA.yml and MYMETA.json
===>  Building for p5-Image-Scale-0.08_6
--- blib/lib/Image/.exists ---
--- blib/arch/.exists ---
--- blib/lib/auto/Image/Scale/.exists ---
--- blib/arch/auto/Image/Scale/.exists ---
--- blib/bin/.exists ---
--- blib/script/.exists ---
--- blib/man1/.exists ---
--- blib/man3/.exists ---
--- subdirs ---
--- blibdirs ---
--- Scale.c ---
/usr/local/bin/perl /usr/local/lib/perl5/5.18/ExtUtils/xsubpp  -typemap /usr/local/lib/perl5/5.18/ExtUtils/typemap -typemap typemap  Scale.xs > Scale.xsc && mv Scale.xsc Scale.c
--- Scale.bs ---
Running Mkbootstrap for Image::Scale ()
chmod 644 Scale.bs
--- pm_to_blib ---
cp lib/Image/Scale.pm blib/lib/Image/Scale.pm
--- config ---
--- blib/arch/auto/Image/Scale/Scale.bs ---
cp Scale.bs blib/arch/auto/Image/Scale/Scale.bs
chmod 644 blib/arch/auto/Image/Scale/Scale.bs
--- Scale.c ---
Please specify prototyping behavior for Scale.xs (see perlxs manual)
--- Scale.o ---
cc -c  -I. -I.. -Isrc -Iinclude -I/usr/local/include -I/usr/local/include  -O2 -pipe -march=native  -fstack-protector -fno-strict-aliasing -O2 -pipe -march=native -fstack-protector -fno-strict-aliasing    -DVERSION=\"0.08\"  -DXS_VERSION=\"0.08\" -DPIC -fPIC "-I/usr/local/lib/perl5/5.18/mach/CORE"  -O2 -Wall -Wno-unused-value -Wno-format-security -Winline -ffast-math -DHAVE_JPEG -DJPEG_VERSION=80 -DHAVE_PNG -DPNG_VERSION=1.6.16 Scale.c
--- blib/arch/auto/Image/Scale/Scale.so ---
rm -f blib/arch/auto/Image/Scale/Scale.so
LD_RUN_PATH="/usr/local/lib:/usr/lib" cc  -shared  -L/usr/ports/lang/perl5.18/work/perl-5.18.4 -L/usr/local/lib/perl5/5.18/mach/CORE -Wl,-rpath=/usr/local/lib/perl5/5.18/mach/CORE -lperl -L/usr/local/lib -fstack-protector Scale.o  -o blib/arch/auto/Image/Scale/Scale.so     -ljpeg -lpng -lz
chmod 755 blib/arch/auto/Image/Scale/Scale.so
--- dynamic ---
--- linkext ---
--- pure_all ---
--- manifypods ---
Manifying blib/man3/Image::Scale.3
--- all ---
cd /usr/ports/graphics/p5-Image-Scale/work/Image-Scale-0.08/ && /usr/bin/env XDG_DATA_HOME=/usr/ports/graphics/p5-Image-Scale/work  XDG_CONFIG_HOME=/usr/ports/graphics/p5-Image-Scale/work  HOME=/usr/ports/graphics/p5-Image-Scale/work NO_PIE=yes SHELL=/bin/sh NO_LINT=YES PREFIX=/usr/local  LOCALBASE=/usr/local  LIBDIR="/usr/lib"  CC="cc" CFLAGS="-O2 -pipe -march=native  -fstack-protector -fno-strict-aliasing"  CPP="cpp" CPPFLAGS=""  LDFLAGS=" -fstack-protector" LIBS=""  CXX="c++" CXXFLAGS="-O2 -pipe -march=native -fstack-protector -fno-strict-aliasing "  MANPREFIX="/usr/local" BSD_INSTALL_PROGRAM="install  -s -o root -g wheel -m 555"  BSD_INSTALL_LIB="install  -s -o root -g wheel -m 444"  BSD_INSTALL_SCRIPT="install  -o root -g wheel -m 555"  BSD_INSTALL_DATA="install  -o root -g wheel -m 0644"  BSD_INSTALL_MAN="install  -o root -g wheel -m 444" /usr/bin/make DESTDIR=/usr/ports/graphics/p5-Image-Scale/work/stage test
PERL_DL_NONLAZY=1 /usr/local/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/01use.t .......... ok
t/02pod.t .......... skipped: set TEST_POD to enable this test
t/03podcoverage.t .. skipped: set TEST_POD to enable this test
t/04critic.t ....... skipped: Critic test only for developers.
t/bmp.t ............ ok
t/gif.t ............ skipped: Image::Scale not built with giflib/libungif support
t/jpeg.t ........... 1/112 # libjpeg version: 80
t/jpeg.t ........... ok
t/png.t ............ 1/46 # libpng version: 1.6.16
t/png.t ............ ok
All tests successful.
Files=8, Tests=189,  0 wallclock secs ( 0.05 usr  0.06 sys +  0.54 cusr  0.22 csys =  0.88 CPU)
Result: PASS
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-03-11 19:14:12 UTC
A commit references this bug:

Author: robak
Date: Wed Mar 11 19:13:58 UTC 2015
New revision: 381029
URL: https://svnweb.freebsd.org/changeset/ports/381029

Log:
  graphics/p5-Image-Scale: fix BROKEN

  - Remove broken code related to gif support (until
    upstream fixes it)

  PR:		197958
  Submitted by:	Mark Atkinson <atkin901@gmail.com>

Changes:
  head/graphics/p5-Image-Scale/Makefile
  head/graphics/p5-Image-Scale/files/patch-Makefile.PL
Comment 4 Bartek Rutkowski freebsd_committer freebsd_triage 2015-03-11 19:15:25 UTC
Committed, thanks for your work!