Bug 198438 - [maintainer update] textproc/ibus-qt: update to 1.3.3
Summary: [maintainer update] textproc/ibus-qt: update to 1.3.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-08 22:01 UTC by Henry Hu
Modified: 2015-03-29 08:16 UTC (History)
1 user (show)

See Also:

Attachments
update ibus-qt to 1.3.3, remove doxygen requirement (2.67 KB, patch)
2015-03-08 22:01 UTC, Henry Hu 		no flags Details | Diff
update ibus-qt to 1.3.3, v2 (3.23 KB, patch)
2015-03-28 18:10 UTC, Henry Hu 		henry.hu.sh: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2015-03-08 22:01:02 UTC 
Created attachment 154042 [details]
update ibus-qt to 1.3.3, remove doxygen requirement

update ibus-qt to 1.3.3, remove Doxygen dependency, rewrite DEPENDS

# make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
# make stage-qa
====> Running Q/A tests (stage-qa)
#
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2015-03-16 08:00:51 UTC 
Is this patch complete? I just built this in poudriere and it was not happy with the plist:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%DOCSDIR%%/AUTHORS
Error: Missing: %%DOCSDIR%%/INSTALL
Error: Missing: %%DOCSDIR%%/README
Error: Missing: @dir %%DOCSDIR%%
===> Error: Plist issues found.
*** Error code 1
Comment 2 John Marino freebsd_committer freebsd_triage 2015-03-27 16:09:31 UTC 
He's asking for a new (tested) patch -- without it this PR will be closed.
Comment 3 Henry Hu 2015-03-28 18:10:38 UTC 
Created attachment 154927 [details]
update ibus-qt to 1.3.3, v2

Sorry for the late response, I had a deadline on Thursday.

Here is the updated patch. I didn't test with the DOCS option for the previous version, and because the port documents are not installed now, and the documents are not very useful, I just remove them from the plist. Now there are no docs, so DOCS option is also removed.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-03-29 08:13:09 UTC 
A commit references this bug:

Author: riggs
Date: Sun Mar 29 08:12:42 UTC 2015
New revision: 382569
URL: https://svnweb.freebsd.org/changeset/ports/382569

Log:
  Update to upstream version 1.3.3

  PR:		198438
  Submitted by:	henry.hu.sh@gmail.com (maintainer)

Changes:
  head/textproc/ibus-qt/Makefile
  head/textproc/ibus-qt/distinfo
  head/textproc/ibus-qt/files/
  head/textproc/ibus-qt/files/patch-CMakeLists.txt
  head/textproc/ibus-qt/pkg-plist
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2015-03-29 08:16:54 UTC 
Thanks for the updated patch!
However, as a small suggestion for future work, poudriere-tested, portlint'ed patches are always very much appreciated.

Committed with the following changes:
- Add LICENSE_FILE
- Remove deprecated @dirrm(try) macros from pkg-plist