Bug 198567 - [UPDATE] audio/pulseaudio to 6.0
Summary: [UPDATE] audio/pulseaudio to 6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-13 19:14 UTC by Olivier Duchateau
Modified: 2015-04-15 21:43 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
Update audio/pulseaudio to 6.0 (6.50 KB, patch)
2015-03-13 19:14 UTC, Olivier Duchateau
no flags Details | Diff
Update audio/pulseaudio to 6.0 (6.68 KB, patch)
2015-03-14 10:19 UTC, Olivier Duchateau
no flags Details | Diff
Update audio/pulseaudio to 6.0 (6.67 KB, patch)
2015-03-26 17:44 UTC, Olivier Duchateau
no flags Details | Diff
Patch to update audio/pulseaudio (6.49 KB, patch)
2015-03-31 03:43 UTC, Olivier Duchateau
no flags Details | Diff
Olivier's patch with 24 bit samples support (7.90 KB, patch)
2015-04-08 03:02 UTC, Romain Tartière
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau freebsd_committer freebsd_triage 2015-03-13 19:14:11 UTC
Created attachment 154274 [details]
Update audio/pulseaudio to 6.0

- Update to 6.0
- Remove libsamplerate (deprecated)
- Fix shebang (bash)

Note: start-pulseaudio-x11 doesn't anymore start PulseAudio. Users must enable explicitly auto-spawning daemon in /usr/local/pulse/client.conf or .config/pulse/client.conf.
Comment 1 Olivier Duchateau freebsd_committer freebsd_triage 2015-03-14 10:19:55 UTC
Created attachment 154290 [details]
Update audio/pulseaudio to 6.0

Add RUN_DEPENDS for bash. It needs to be installed if users launch PulseAudio with pulseaudio script.
Comment 2 Olivier Duchateau freebsd_committer freebsd_triage 2015-03-26 17:44:46 UTC
Created attachment 154838 [details]
Update audio/pulseaudio to 6.0

Update patch, remove $PTHREAD_LIBS like in latest commit.
Comment 3 Koop Mast freebsd_committer freebsd_triage 2015-03-29 08:44:26 UTC
(In reply to Olivier Duchateau from comment #1)

What is the script you noticed that needs bash to run? The only bash scripts I see are the bash shell completion scripts. Which could be installed without bash present.
Comment 4 Olivier Duchateau freebsd_committer freebsd_triage 2015-03-30 17:27:12 UTC
(In reply to Koop Mast from comment #3)

It's exactly this shell script. As I don't use Bash shell, PulseAudio works fine without it.
Comment 5 Olivier Duchateau freebsd_committer freebsd_triage 2015-03-31 03:43:39 UTC
Created attachment 155041 [details]
Patch to update audio/pulseaudio

Remove bash as dependency (I left 'shebangfix' macro, in order to fix shebang line in bash completion script).
Comment 6 Romain Tartière freebsd_committer freebsd_triage 2015-04-08 03:02:40 UTC
Created attachment 155328 [details]
Olivier's patch with 24 bit samples support

The attached patch is a copy of Olivier's one except I added a patch I use locally that makes PulseAudio capable of using 24 bit format (my sound card does not support 16 bit formats and with dev.pcm.0.bitperfect=1, I can't use PulseAudio with it).

According to the comments, this is supposed to be unsupported, but as far as I can hear, it's working perfectly (and with a better audio quality in regard to disabling bitperfect and letting OSS perfom the convertion).  So maybe the comment is only applicable to Linux systems?
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-04-15 21:42:23 UTC
A commit references this bug:

Author: kwm
Date: Wed Apr 15 21:41:28 UTC 2015
New revision: 384072
URL: https://svnweb.freebsd.org/changeset/ports/384072

Log:
  Update pulseaudio to 6.0 [1].

  * Correct some paths in the default config file (default.pa). [1]
  * Add run depend freedesktop-sound-theme since pulse tries to run these files.
  * Add a small patch to allow 24bit audio formats, it not clear why this is
    disabled by default. [2]
  * Add pkg-message with instructions how to set input/output channel.
  * The kde start script was merged into the normal x11 start script.

  PR:		198567 [1], [2]
  Submitted by:	olivierd@ [1], romain@ [2]

Changes:
  head/audio/pulseaudio/Makefile
  head/audio/pulseaudio/distinfo
  head/audio/pulseaudio/files/patch-src_daemon_default.pa.in
  head/audio/pulseaudio/files/patch-src_modules_oss_oss-util.c
  head/audio/pulseaudio/files/patch-src_pulse_thread-mainloop.c
  head/audio/pulseaudio/files/patch-src_pulse_util.c
  head/audio/pulseaudio/files/patch-src_pulsecore_atomic.h
  head/audio/pulseaudio/files/pkg-message.in
  head/audio/pulseaudio/pkg-plist