Bug 198709 - [New port] devel/unibilium: a terminfo parsing library
Summary: [New port] devel/unibilium: a terminfo parsing library
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks: 198711 198713
  Show dependency tree / graph
 
Reported: 2015-03-19 16:51 UTC by Anton Törnqvist
Modified: 2015-05-28 09:17 UTC (History)
1 user (show)

See Also:

Attachments
unibilium.shar (3.78 KB, application/x-shar)
2015-03-19 16:51 UTC, Anton Törnqvist 		no flags Details
poudriere-buildlog-10amd64-unibilium (24.27 KB, text/plain)
2015-03-19 16:52 UTC, Anton Törnqvist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Törnqvist 2015-03-19 16:51:28 UTC 
Created attachment 154523 [details]
unibilium.shar
Comment 1 Anton Törnqvist 2015-03-19 16:52:32 UTC 
Created attachment 154524 [details]
poudriere-buildlog-10amd64-unibilium
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-27 15:25:56 UTC 
This needs improvements and modernization. For instance, you may not use GH_COMMIT. Are you ok with these?

- Properly use github tags, changes distinfo
- Add LICENSE_FILE
- Build needs pod2man from perl5
- Strip .so to not update this line when lib version changes

--- unibilium.orig/Makefile     2015-05-27 18:09:39.099072000 +0300
+++ unibilium/Makefile  2015-05-27 18:08:46.708875000 +0300
@@ -3,25 +3,26 @@
 
 PORTNAME=      unibilium
 PORTVERSION=   1.1.2
+DISTVERSIONPREFIX=     v
 CATEGORIES=    devel
 
 MAINTAINER=    antont@inbox.lv
 COMMENT=       Unibilium is a very basic terminfo library
 
 LICENSE=       LGPL3
+LICENSE_FILE=  ${WRKSRC}/LGPLv3
 
 USE_GITHUB=    yes
 GH_ACCOUNT=    mauke
-GH_COMMIT=     d7c348a
-GH_TAGNAME=    v${PORTVERSION}
 
-USES=          gmake libtool:build pkgconfig
+USES=          gmake libtool:build perl5 pkgconfig
+USE_PERL5=     build
 USE_LDCONFIG=  yes
 
 pre-build:
        ${REINPLACE_CMD} -e 's|$$(LIBDIR)/pkgconfig|${PREFIX}/libdata/pkgconfig|g' ${WRKSRC}/Makefile
 
-post-stage:
-       ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libunibilium.so.0.2.1
+post-install:
+       ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libunibilium.so
 
 .include <bsd.port.mk>
diff -u unibilium.orig/distinfo unibilium/distinfo
--- unibilium.orig/distinfo     2015-05-27 18:09:39.097738000 +0300
+++ unibilium/distinfo  2015-05-27 18:06:41.958965000 +0300
@@ -1,2 +1,2 @@
-SHA256 (unibilium-1.1.2.tar.gz) = 5c9570ee0cbdb0062f86d580672e2d134b6c8240a96bc8eab2cd91a24998f147
-SIZE (unibilium-1.1.2.tar.gz) = 76845
+SHA256 (mauke-unibilium-v1.1.2_GH0.tar.gz) = bdf3750b9e6ecdb30ba42dd0ef041c34222051495ff420c8c76d391f11e149e3
+SIZE (mauke-unibilium-v1.1.2_GH0.tar.gz) = 76823
Comment 3 Anton Törnqvist 2015-05-27 15:35:29 UTC 
Looks good.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-05-28 09:17:51 UTC 
A commit references this bug:

Author: amdmi3
Date: Thu May 28 09:17:03 UTC 2015
New revision: 387712
URL: https://svnweb.freebsd.org/changeset/ports/387712

Log:
  Unibilium is a very basic terminfo library. It doesn't depend on curses or any
  other library. It also doesn't use global variables, so it should be
  thread-safe.

  WWW: https://github.com/mauke/unibilium

  PR:		198709
  Submitted by:	antont@inbox.lv

Changes:
  head/devel/Makefile
  head/devel/unibilium/
  head/devel/unibilium/Makefile
  head/devel/unibilium/distinfo
  head/devel/unibilium/pkg-descr
  head/devel/unibilium/pkg-plist