Bug 198721 - [MAINTAINER] net/tigervnc: Update to 1.4.3
Summary: [MAINTAINER] net/tigervnc: Update to 1.4.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-03-19 22:08 UTC by Georgy Lukyanchenko
Modified: 2015-03-24 03:25 UTC (History)
2 users (show)

See Also:
meta: maintainer-feedback+

Attachments
patch for net/tigervnc (4.60 KB, patch)
2015-03-21 21:41 UTC, Georgy Lukyanchenko 		no flags Details | Diff
corrected patch after check by portlint (4.75 KB, patch)
2015-03-21 22:05 UTC, Georgy Lukyanchenko 		no flags Details | Diff
update to 1.4.3 (5.34 KB, patch)
2015-03-23 05:01 UTC, Koichiro Iwao 		no flags Details | Diff
poudriere build log (689.25 KB, text/plain)
2015-03-23 06:17 UTC, Koichiro Iwao 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Lukyanchenko 2015-03-19 22:08:25 UTC 
Please consider updating TigerVNC port to the latest version (currently 1.4.3). Among other improvements it should also solve longstanding issue with Ctrl-hotkeys in vncviewer (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=182006 & https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=181345 ). FLTK 1.3.3 which do not need custom TigerVNC patches is already in ports, but Ctrl-keys function properly only on FLTK 1.3.3 + TigerVNC 1.4.X (more info here https://github.com/TigerVNC/tigervnc/issues/8). I've tried building official TigerVNC 1.4.3 source from GitHub without any FreeBSD specific patches on FreeBSD 10.1-RELEASE-p5 with current ports x11-toolkits/fltk and it compiled and works just fine (including Ctrl-hotkeys). So it seems that port update should be easy.
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2015-03-19 23:35:27 UTC 
I'll make an update on this weekend, thanks.
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2015-03-20 02:15:56 UTC 
Can you attach the patch if you already made to update TigerVNC port?
Comment 3 Georgy Lukyanchenko 2015-03-21 21:41:38 UTC 
Created attachment 154641 [details]
patch for net/tigervnc
Comment 4 Georgy Lukyanchenko 2015-03-21 22:02:58 UTC 
I've attached a patch for net/tigervnc. Please note that this is my first attempt to make a patch for a port, I hope I've done everything right. Tigervnc migrated to GitHub, so I've set USE_GITHUB. With it I've faced the problem that WRKSRC is defined as ${WRKDIR}/${GH_ACCOUNT}-${GH_PROJECT}-${GH_COMMIT}, but at least for tigervnc last part is not actually a commit code, but something different. So I had to set GH_COMMIT to ac9622c, although actual commit for 1.4.3 is 49d0629. Not sure this is the correct way. Also I've removed patch-hw-vnc-off-by-one-error and patch-vncviewer-always-built as these patches failed to apply and they seem not to be needed anymore. I've observed no difference whenever patch-unix_vncserver was applied or not, but decided to keep it.
Comment 5 Georgy Lukyanchenko 2015-03-21 22:05:07 UTC 
Created attachment 154642 [details]
corrected patch after check by portlint
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2015-03-23 04:00:51 UTC 
Thanks! I'm testing your patch and will make minor modification.
Comment 7 Koichiro Iwao freebsd_committer freebsd_triage 2015-03-23 05:01:47 UTC 
Created attachment 154686 [details]
update to 1.4.3

Update to 1.4.3

Release Note: https://github.com/TigerVNC/tigervnc/releases/tag/v1.4.3


note: files/patch-hw-vnc-off-by-one-error and files/patch-vncviewer-always-built are deleted.
Comment 8 Koichiro Iwao freebsd_committer freebsd_triage 2015-03-23 06:17:53 UTC 
Created attachment 154690 [details]
poudriere build log

#154641 and #154642 are obsoleted. I'm not privileged to mark them obsoleted.
Would any committers please mark them obsolete?
Comment 9 Koichiro Iwao freebsd_committer freebsd_triage 2015-03-23 06:18:40 UTC 
Done. Waiting for committers.
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2015-03-23 21:17:57 UTC 
testing@work
Comment 11 commit-hook freebsd_committer freebsd_triage 2015-03-24 03:24:49 UTC 
A commit references this bug:

Author: pi
Date: Tue Mar 24 03:24:30 UTC 2015
New revision: 382065
URL: https://svnweb.freebsd.org/changeset/ports/382065

Log:
  net/tigervnc: 1.3.1 -> 1.4.3

  Release-Notes:
    https://github.com/TigerVNC/tigervnc/releases/tag/v1.4.3
    - should solve longstanding issue with Ctrl-hotkeys in vncviewer
      https://github.com/TigerVNC/tigervnc/issues/8

  PR:		198721
  Submitted by:	Koichiro Iwao <meta+ports@vmeta.jp> (maintainer)
  Requested by:	Georgy Lukyanchenko <egorxe@gmail.com>

Changes:
  head/net/tigervnc/Makefile
  head/net/tigervnc/distinfo
  head/net/tigervnc/files/patch-hw-vnc-off-by-one-error
  head/net/tigervnc/files/patch-vncviewer-always-built
  head/net/tigervnc/pkg-plist
Comment 12 Kurt Jaeger freebsd_committer freebsd_triage 2015-03-24 03:25:20 UTC 
build-tests worked fine on 10.1a, 9.3a, 8.4i.

Committed, thanks very much!