Created attachment 154786 [details] Patchset for net/hostapd Update net/hostapd to 2.4. Make base/ports SSL configuration explicit by adding a PORTS_SSL option.
Created attachment 154787 [details] Patchset for net/hostapd
Created attachment 154788 [details] poudriere log for net/hostapd
Did you used <bsd.port.pre.mk> over <bsd.options.mk> intentionally? if so, was it to expose a variable?
(In reply to John Marino from comment #3) No, I copied it from a bad example. Stand by for new uploads.
Created attachment 154871 [details] Patchset for net/hostapd Revised patchset
Created attachment 154872 [details] updated poudriere log
A commit references this bug: Author: marino Date: Sun Mar 29 12:15:41 UTC 2015 New revision: 382595 URL: https://svnweb.freebsd.org/changeset/ports/382595 Log: net/hostapd: Upgrade version 2.3 => 2.4, add PORTS_SSL option PR: 198889 Submitted by: maintainer (leres - ee.lbl.gov) Changes: head/net/hostapd/Makefile head/net/hostapd/distinfo
Nice job, thanks!
mat thinks the openssl handling is too complex and can be done simpler: https://lists.freebsd.org/pipermail/svn-ports-head/2015-March/087545.html Please update the PR accordingly if you agree.
> That seems way overly complicated, why not just do: > > .if defined(WITH_OPENSSL_PORT) > CONFIGURE_ARGS+= --with-ssl-dir=${PREFIX} > .endif That looks like a nice way to insure a port uses the base/ports version of openssl at the time its package is built. The problem I'm trying to solve is if I've decided to use the ports version of openssl, I want to eliminate the possibility that if I accidently build a port when the openssl port *isn't* installed, it will use the base openssl. Does that make sense? A possibly optimization to the way I've implemented this might be to set: WITH_OPENSSL_PORT=yes instead of setting the IGNORE if the port isn't installed.
> does that make sense? no, not really. if WITH_OPENSSL_PORT is set, it's probably set by /etc/make.conf, meaning all ports are going to use the base version. I agree with mat on two things: 1) This is probably overthinking 2) This is geared for building on live systems instead of binary packages. You should be focusing on the latter (i.e. building in poudriere clean jail) because live system building is just about deprecated given all the problems that can arise.
(In reply to John Marino from comment #11) "meaning all ports are going to use the base version." correction: "meaning all ports are going to use the selected version (either all base or all port)"