Bug 199017 - sysutils/rubygem-facter fails patch if ZFS_FACTS is disabled
Summary: sysutils/rubygem-facter fails patch if ZFS_FACTS is disabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Bartek Rutkowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-30 09:56 UTC by Remko Catersels
Modified: 2015-03-30 19:45 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (robak)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Remko Catersels 2015-03-30 09:56:40 UTC
sysutils/rubygem-facter fails the patch stage if ZFS_FACTS is disabled.

ZFS_FACTS enabled:
root@c1:/usr/ports/sysutils/rubygem-facter# make clean
===>  Cleaning for rubygem-facter-2.4.1
root@c1:/usr/ports/sysutils/rubygem-facter# make showconfig
===> The following configuration options are available for rubygem-facter-2.4.1:
     ZFS_FACTS=on: Generate ZFS-related facts
===> Use 'make config' to modify these settings
root@c1:/usr/ports/sysutils/rubygem-facter# make patch
===>  License APACHE20 accepted by the user
===>  Found saved configuration for rubygem-facter-2.4.1
===>   rubygem-facter-2.4.1 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by rubygem-facter-2.4.1 for building
===>  Extracting for rubygem-facter-2.4.1
=> SHA256 Checksum OK for rubygem/facter-2.4.1.gem.
===>   rubygem-facter-2.4.1 depends on file: /usr/local/bin/gem21 - found
===>   rubygem-facter-2.4.1 depends on file: /usr/local/bin/ruby21 - found
Unpacked gem: '/usr/ports/sysutils/rubygem-facter/work/facter-2.4.1'
===>  Patching for rubygem-facter-2.4.1
===>   rubygem-facter-2.4.1 depends on file: /usr/local/bin/ruby21 - found

ZFS_FACTS disabled:
root@c1:/usr/ports/sysutils/rubygem-facter# make clean
===>  Cleaning for rubygem-facter-2.4.1
root@c1:/usr/ports/sysutils/rubygem-facter# make showconfig
===> The following configuration options are available for rubygem-facter-2.4.1:
     ZFS_FACTS=off: Generate ZFS-related facts
===> Use 'make config' to modify these settings
root@c1:/usr/ports/sysutils/rubygem-facter# make patch
===>  License APACHE20 accepted by the user
===>  Found saved configuration for rubygem-facter-2.4.1
===>   rubygem-facter-2.4.1 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by rubygem-facter-2.4.1 for building
===>  Extracting for rubygem-facter-2.4.1
=> SHA256 Checksum OK for rubygem/facter-2.4.1.gem.
===>   rubygem-facter-2.4.1 depends on file: /usr/local/bin/gem21 - found
===>   rubygem-facter-2.4.1 depends on file: /usr/local/bin/ruby21 - found
Unpacked gem: '/usr/ports/sysutils/rubygem-facter/work/facter-2.4.1'
===>  Patching for rubygem-facter-2.4.1
===>   rubygem-facter-2.4.1 depends on file: /usr/local/bin/ruby21 - found
sed: /usr/ports/sysutils/rubygem-facter/work/facter-2.4.1/facter-2.4.1.gemspec: No such file or directory
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/sysutils/rubygem-facter
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/rubygem-facter
Comment 1 Bartek Rutkowski freebsd_committer freebsd_triage 2015-03-30 12:47:08 UTC
I cant reproduce it, both disabled and enabled versions are building fine. Are you sure its not something on your system? Can you try on a freshly installed OS with latest SVN ports tree version, making sure you're doing 'make clean distclean' after each iteration?
Comment 2 Remko Catersels 2015-03-30 13:07:48 UTC
I'm sure it's not something on my systems. I've had three completely different systems fail at the same point. 

Poudriere (has it's own ports tree; svn) fails.
The host system (has it's own ports tree; portsnap) fails.
Several, different, systems at home, fail.
A clean install of FreeBSD 10.1 in a Virtualbox VM, fails.
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-03-30 19:45:13 UTC
A commit references this bug:

Author: robak
Date: Mon Mar 30 19:44:56 UTC 2015
New revision: 382717
URL: https://svnweb.freebsd.org/changeset/ports/382717

Log:
  sysutils/rubygem-facter: fix build with ZFS_FACTS disabled

  - Upstream changed the name of the gemspec to not include version number, this change
    is to accomodate to that change

  PR:		199017

Changes:
  head/sysutils/rubygem-facter/Makefile
Comment 4 Bartek Rutkowski freebsd_committer freebsd_triage 2015-03-30 19:45:54 UTC
Fixed, thanks for pointing that out!