Bug 199228 - [PATCH] finance/moneymanagerex: Update to version 1.0.0.0
Summary: [PATCH] finance/moneymanagerex: Update to version 1.0.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-04-06 18:43 UTC by tkato432
Modified: 2015-10-10 13:54 UTC (History)
2 users (show)

See Also:

Attachments
finance_moneymanagerex.diff (7.50 KB, patch)
2015-04-06 18:43 UTC, tkato432 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2015-04-06 18:43:35 UTC 
Created attachment 155266 [details]
finance_moneymanagerex.diff
Comment 1 Alexey Dokuchaev freebsd_committer freebsd_triage 2015-04-12 08:55:57 UTC 
Explain the need for pkg-descr reformat?  I created this port and payed special attention so port description looks nice.  Your version makes it look worse (has ragged right edge) for no apparent benefit.
Comment 2 tkato432 2015-04-14 11:01:32 UTC 
When submitting ports PRs, I've been usually folded pkg-descr as
72 characters per line. My personal impression is that 75 is a
little too wide.

I won't make any further objections if you'll decide to exclude
the change for pkg-descr since original version doesn't violate
the ports specification which only defines the hard limit as
80x25.
Comment 3 John Marino freebsd_committer freebsd_triage 2015-10-10 10:50:20 UTC 
I use 75 characters as the limit.

I support rewrapping that respects 75, but 72 is a bit too low IMO.
Comment 4 John Marino freebsd_committer freebsd_triage 2015-10-10 12:21:55 UTC 
crap, this one has abused PORTDOCS too.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-10-10 13:53:31 UTC 
A commit references this bug:

Author: marino
Date: Sat Oct 10 13:52:44 UTC 2015
New revision: 398995
URL: https://svnweb.freebsd.org/changeset/ports/398995

Log:
  finance/moneymanagerx: Upgrade version 0.9.9.0 => 1.0.0.0

  The PR was modified.  The PORTDATA change was not accepted.  The
  rewrapping of pkg-descr from 75 to 72 character width was not accepted.
  USE_AUTOTOOLS did get added and I kept it because I couldn't make
  USES=autoreconf work out of the box.  It's needs some customization and
  I'm not familar enough with automake to get it to work, so check-sanity
  squawks but it passes the build.

  While here, add a patch to support DragonFly

  PR:		199228
  Submitted by:	ports fury

Changes:
  head/finance/moneymanagerex/Makefile
  head/finance/moneymanagerex/distinfo
  head/finance/moneymanagerex/files/
  head/finance/moneymanagerex/files/patch-bakefile-0.2.9_autoconf_bakefile.m4
  head/finance/moneymanagerex/pkg-plist
Comment 6 John Marino freebsd_committer freebsd_triage 2015-10-10 13:54:42 UTC 
The PORTDATA rejection was painful.  I'm not doing that again.