Bug 199640 - devel/ccache: add clang36 link
Summary: devel/ccache: add clang36 link
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-23 09:41 UTC by Dmitry Marakasov
Modified: 2015-04-23 15:27 UTC (History)
0 users

See Also:
bdrewery: maintainer-feedback+


Attachments
Patch (476 bytes, patch)
2015-04-23 09:41 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-04-23 09:41:04 UTC
Created attachment 155900 [details]
Patch

- add links for clang36

I may have forgotten, but why doesn't the port enable CLANGLINK LLVMLINK by default?
Comment 1 Bryan Drewery freebsd_committer freebsd_triage 2015-04-23 14:54:46 UTC
Please commit. You may have implicit approval to add links as needed in the future.

It's not enabled by default since clang+ccache has been unreliable in the past. The last time I tried a head build it bombed with some --sysroot error. However I do build ports just fine with it. I believe some of brooks@ work did fix the --sysroot issue. I'll run some head builds to see.

Clang+ccache still requires CCACHE_CPP2 (which I force enable by default in devel/ccache) due to clang not liking extra parenthesis from expanded macros.
For example:

#define MACRO(x) (dosomething(x))
if (MACRO(x))
 ;

Ccache passes the preprocessed version to clang:

if ((dosomething(x))
 ;

If I remember right it will then error when used with a certain -W flag about having unneeded parenthesis. It would be nice if clang was more forgiving here so the ccache/cpp optimization could be re-enabled.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-04-23 15:27:34 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Apr 23 15:27:15 UTC 2015
New revision: 384592
URL: https://svnweb.freebsd.org/changeset/ports/384592

Log:
  - Add link for clang36

  PR:		199640
  Submitted by:	amdmi3
  Approved by:	bdrewery (maintainer)

Changes:
  head/devel/ccache/Makefile