Bug 199865 - [patch] editors/openoffice-devel: fix build for some non-default OPTIONS
Summary: [patch] editors/openoffice-devel: fix build for some non-default OPTIONS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Don Lewis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-02 17:52 UTC by Kurt Jaeger
Modified: 2015-05-05 20:50 UTC (History)
1 user (show)

See Also:


Attachments
patch (686 bytes, patch)
2015-05-02 17:52 UTC, Kurt Jaeger
no flags Details | Diff
patch to add missing dependencies and tweak options (3.18 KB, patch)
2015-05-04 16:55 UTC, Don Lewis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2015-05-02 17:52:38 UTC
Created attachment 156239 [details]
patch

Fixes build if only OPTION CUPS is selected.

Adds explicit BUILD_DEPENDS

dbus-binding-tool:${PORTSDIR}/devel/dbus-glib

sucessful poudriere log for 10.1a at

http://people.freebsd.org/~pi/logs/apache-openoffice-devel-4.2.1667428,3.log

and failed build at:

http://people.freebsd.org/~pi/logs/apache-openoffice-devel-4.2.1667428,3.log-fail
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2015-05-02 18:04:14 UTC
maintainer assumes that this problem affects editors/openoffice-4 as well.
Comment 2 Don Lewis freebsd_committer freebsd_triage 2015-05-04 16:55:34 UTC
Created attachment 156344 [details]
patch to add missing dependencies and tweak options

It turns out that devel/dbus-glib needs to be a LIB_DEPENDS because configure looks for libdbus-glib-1.so and this library gets linked into the application.  There is also a configure knob to turn off this dependency, so I followed the lead of the libreoffice port and renamed the GCONF option to GNOME and moved both configure knobs and the dependencies under that option.

I also added an option to turn control the gstreamer dependency.

In my experimentation, I found a couple of missing perl dependencies and added them.

Plus a few other minor tweaks.
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-05-05 20:38:49 UTC
A commit references this bug:

Author: truckman
Date: Tue May  5 20:38:34 UTC 2015
New revision: 385489
URL: https://svnweb.freebsd.org/changeset/ports/385489

Log:
  Unbreak editors/openoffice-* build when GCONF and GNOMEVFS are disabled

  There is a missing dependency on devel/dbus-glib that causes the
  openoffice build to fail when the GCONF and GNOMEVFS options are
  disabled. When these options are enabled, one of the dependencies
  added by these options brings along dbus-glib so the default build
  succeeds.

  There is a configure knob to control whether or not dbus-glib is
  used, so follow the lead of the libreoffice port and rename the
  GCONF option to GNOME and bundle both Gconf and DBUS handling under
  the GNOME option.

  Borrow the MMEDIA option from the libreoffice port and use that to
  control the using of gstreamer.

  Add a couple of missing p5-* build dependencies.

  Add the --enable-gtk, --disable-kde, --disable-kde4 configure flags
  so that the port does not try to build with KDE if it is installed
  because compilation fails.

  USE_AUTOTOOLS=autoconf -> USES=autoreconf:autoconf

  PR:		199865
  Reported by:	pi
  Differential Revision:	https://reviews.freebsd.org/D2441
  Reviewed by:	pi, pfg
  Approved by:	mat (mentor)

Changes:
  head/editors/openoffice-4/Makefile
  head/editors/openoffice-devel/Makefile