Bug 200308 - [PATCH] x11-fonts/tmu: Update MASTER_SITES
Summary: [PATCH] x11-fonts/tmu: Update MASTER_SITES
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-05-18 18:40 UTC by tkato432
Modified: 2015-05-19 08:14 UTC (History)
0 users

See Also:


Attachments
x11-fonts_tmu.diff (2.09 KB, patch)
2015-05-18 18:40 UTC, tkato432
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2015-05-18 18:40:04 UTC
Created attachment 156908 [details]
x11-fonts_tmu.diff
Comment 1 John Marino freebsd_committer freebsd_triage 2015-05-19 07:49:48 UTC
This patch has a couple of things I'm going to change.

Even if I would keep the patch as it is, the second line of the "do-install:" target would not be changed.  Many times feedback has been given not to change a working single command into 2 separate commands for no reason.
Comment 2 John Marino freebsd_committer freebsd_triage 2015-05-19 07:52:26 UTC
also, this is GPLv3, not GPLv2, according to SF download site
Comment 3 John Marino freebsd_committer freebsd_triage 2015-05-19 07:56:01 UTC
EXTRACT_BEFOR_ARGS is a typo
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-05-19 08:11:50 UTC
A commit references this bug:

Author: marino
Date: Tue May 19 08:11:44 UTC 2015
New revision: 386747
URL: https://svnweb.freebsd.org/changeset/ports/386747

Log:
  x11-fonts/tmu: Find new file source to unbreak

  The distfile was available in an uncompressed form on Sourceforge.
  While here, mark as GPLv3 (copying file would have to be downloaded
  separately so it is not set) and simplify.  I made several corrections
  and removals to the patch as submitted.

  PR:		200308
  Submitted by:	Ports Fury

Changes:
  head/x11-fonts/tmu/Makefile
  head/x11-fonts/tmu/distinfo
  head/x11-fonts/tmu/pkg-descr
Comment 5 John Marino freebsd_committer freebsd_triage 2015-05-19 08:14:14 UTC
The post-extract target was completely unnecessary, the install target was adjusted to compensate for it's removal. 

The PLIST_FILES was changed to use %% variables which is incorrect (although it seemed to work), so I put it back.

I moved lines around to minimize the changes seen via "svn diff".


This was not a great patch, it had several problems with it.