Created attachment 157646 [details] fixed fixed. You are receiving this mail as a port that you maintain is failing to build on the FreeBSD package build server. Please investigate the failure and submit a PR to fix build. Maintainer: xjflyttp@gmail.com Last committer: pi@FreeBSD.org Ident: $FreeBSD: branches/2015Q2/ftp/vsftpd-ext/Makefile 376656 2015-01-09 20:11:59Z pi $ Log URL: http://beefy3.nyi.freebsd.org/data/93i386-quarterly/389019/logs/vsftpd-ext-3.0.2.1_2.log Build URL: http://beefy3.nyi.freebsd.org/build.html?mastername=93i386-quarterly&build=389019 Log: ====>> Building ftp/vsftpd-ext build started at Thu Jun 11 05:09:22 UTC 2015 port directory: /usr/ports/ftp/vsftpd-ext building for: FreeBSD 93i386-quarterly-job-24 9.3-RELEASE-p15 FreeBSD 9.3-RELEASE-p15 i386 maintained by: xjflyttp@gmail.com Makefile ident: $FreeBSD: branches/2015Q2/ftp/vsftpd-ext/Makefile 376656 2015-01-09 20:11:59Z pi $ Poudriere version: 3.1.7 Host OSVERSION: 1100070 Jail OSVERSION: 903000 ---Begin Environment--- UNAME_p=i386 UNAME_m=i386 OSVERSION=903000 UNAME_v=FreeBSD 9.3-RELEASE-p15 UNAME_r=9.3-RELEASE-p15 BLOCKSIZE=K MAIL=/var/mail/root STATUS=1 SAVED_TERM=screen MASTERMNT=/usr/local/poudriere/data/.m/93i386-quarterly/ref PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin POUDRIERE_BUILD_TYPE=bulk PKGNAME=vsftpd-ext-3.0.2.1_2 OLDPWD=/ PWD=/usr/local/poudriere/data/.m/93i386-quarterly/ref/.p/pool MASTERNAME=93i386-quarterly SCRIPTPREFIX=/usr/local/share/poudriere USER=root HOME=/root POUDRIERE_VERSION=3.1.7 SCRIPTPATH=/usr/local/share/poudriere/bulk.sh LIBEXECPREFIX=/usr/local/libexec/poudriere LOCALBASE=/usr/local PACKAGE_BUILDING=yes ---End Environment--- ---Begin OPTIONS List--- ===> The following configuration options are available for vsftpd-ext-3.0.2.1_2: DOCS=on: Build and/or install documentation RC_SCRIPT=on: install RC_SCRIPT VSFTPD_SSL=off: Include support for SSL ===> Use 'make config' to modify these settings ---End OPTIONS List--- --CONFIGURE_ARGS-- --End CONFIGURE_ARGS-- --CONFIGURE_ENV-- MAKE=gmake XDG_DATA_HOME=/wrkdirs/usr/ports/ftp/vsftpd-ext/work XDG_CONFIG_HOME=/wrkdirs/usr/ports/ftp/vsftpd-ext/work HOME=/wrkdirs/usr/ports/ftp/vsftpd-ext/work TMPDIR="/tmp" SHELL=/bin/sh CONFIG_SHELL=/bin/sh --End CONFIGURE_ENV-- --MAKE_ENV-- XDG_DATA_HOME=/wrkdirs/usr/ports/ftp/vsftpd-ext/work XDG_CONFIG_HOME=/wrkdirs/usr/ports/ftp/vsftpd-ext/work HOME=/wrkdirs/usr/ports/ftp/vsftpd-ext/work TMPDIR="/tmp" NO_PIE=yes SHELL=/bin/sh NO_LINT=YES PREFIX=/usr/local LOCALBASE=/usr/local LIBDIR="/usr/lib" CC="cc" CFLAGS="-O2 -pipe -fno-strict-aliasing" CPP="cpp" CPPFLAGS="" LDFLAGS="" LIBS="" CXX="c++" CXXFLAGS="-O2 -pipe -fno-strict-aliasing" MANPREFIX="/usr/local" BSD_INSTALL_PROGRAM="install -s -o root -g wheel -m 555" BSD_INSTALL_LIB="install -s -o root -g wheel -m 444" BSD_INSTALL_SCRIPT="install -o root -g wheel -m 555" BSD_INSTALL_DATA="install -o root -g wheel -m 0644" BSD_INSTALL_MAN="install -o root -g wheel -m 444" --End MAKE_ENV-- --PLIST_SUB-- OSREL=9.3 PREFIX=%D LOCALBASE=/usr/local RESETPREFIX=/usr/local PORTDOCS="" PORTEXAMPLES="" LIB32DIR=lib DOCSDIR="share/doc/vsftpd-ext" EXAMPLESDIR="share/examples/vsftpd-ext" DATADIR="share/vsftpd-ext" WWWDIR="www/vsftpd-ext" ETCDIR="etc/vsftpd-ext" --End PLIST_SUB-- --SUB_LIST-- PREFIX=/usr/local LOCALBASE=/usr/local DATADIR=/usr/local/share/vsftpd-ext DOCSDIR=/usr/local/share/doc/vsftpd-ext EXAMPLESDIR=/usr/local/share/examples/vsftpd-ext WWWDIR=/usr/local/www/vsftpd-ext ETCDIR=/usr/local/etc/vsftpd-ext --End SUB_LIST-- ---Begin make.conf--- MACHINE=i386 MACHINE_ARCH=i386 ARCH=${MACHINE_ARCH} USE_PACKAGE_DEPENDS=yes BATCH=yes WRKDIRPREFIX=/wrkdirs PORTSDIR=/usr/ports PACKAGES=/packages DISTDIR=/distfiles #### /usr/local/etc/poudriere.d/make.conf #### MASTER_SITE_FREEBSD=yes DISABLE_MAKE_JOBS=poudriere ---End make.conf--- =======================<phase: check-sanity >============================ ===> License GPLv2 accepted by the user =========================================================================== =======================<phase: pkg-depends >============================ ===> vsftpd-ext-3.0.2.1_2 depends on file: /usr/local/sbin/pkg - not found ===> Verifying install for /usr/local/sbin/pkg in /usr/ports/ports-mgmt/pkg ===> Installing existing package /packages/All/pkg-1.4.12.txz [93i386-quarterly-job-24] Installing pkg-1.4.12... [93i386-quarterly-job-24] Extracting pkg-1.4.12... done Message for pkg-1.4.12: If you are upgrading from the old package format, first run: # pkg2ng ===> Returning to build of vsftpd-ext-3.0.2.1_2 =========================================================================== =======================<phase: fetch-depends >============================ =========================================================================== =======================<phase: fetch >============================ ===> License GPLv2 accepted by the user ===> Fetching all distfiles required by vsftpd-ext-3.0.2.1_2 for building =========================================================================== =======================<phase: checksum >============================ ===> License GPLv2 accepted by the user ===> Fetching all distfiles required by vsftpd-ext-3.0.2.1_2 for building => SHA256 Checksum OK for vsFTPd-3.0.2-ext1.tgz. =========================================================================== =======================<phase: extract-depends>============================ =========================================================================== =======================<phase: extract >============================ ===> License GPLv2 accepted by the user ===> Fetching all distfiles required by vsftpd-ext-3.0.2.1_2 for building ===> Extracting for vsftpd-ext-3.0.2.1_2 => SHA256 Checksum OK for vsFTPd-3.0.2-ext1.tgz. =========================================================================== =======================<phase: patch-depends >============================ =========================================================================== =======================<phase: patch >============================ ===> Patching for vsftpd-ext-3.0.2.1_2 ===> Applying FreeBSD patches for vsftpd-ext-3.0.2.1_2 =========================================================================== =======================<phase: build-depends >============================ ===> vsftpd-ext-3.0.2.1_2 depends on executable: gmake - not found ===> Verifying install for gmake in /usr/ports/devel/gmake ===> Installing existing package /packages/All/gmake-4.1_1.txz [93i386-quarterly-job-24] Installing gmake-4.1_1... [93i386-quarterly-job-24] `-- Installing gettext-runtime-0.19.4... [93i386-quarterly-job-24] | `-- Installing indexinfo-0.2.3... [93i386-quarterly-job-24] | `-- Extracting indexinfo-0.2.3... done [93i386-quarterly-job-24] | `-- Installing libiconv-1.14_6... [93i386-quarterly-job-24] | `-- Extracting libiconv-1.14_6... done [93i386-quarterly-job-24] `-- Extracting gettext-runtime-0.19.4... done [93i386-quarterly-job-24] Extracting gmake-4.1_1... done ===> Returning to build of vsftpd-ext-3.0.2.1_2 =========================================================================== =======================<phase: lib-depends >============================ =========================================================================== =======================<phase: configure >============================ ===> Configuring for vsftpd-ext-3.0.2.1_2 /usr/bin/sed -i.bak -e "s|#undef VSF_BUILD_TCPWRAPPERS|#define VSF_BUILD_TCPWRAPPERS 1|" /wrkdirs/usr/ports/ftp/vsftpd-ext/work/vsFTPd-3.0.2-ext.1/builddefs.h /usr/bin/sed -i.bak -e "s|#define VSF_CONFIG_PATH \"/etc/vsftpd/\"|#define VSF_CONFIG_PATH \"/usr/local/etc/\"|" -e "s|#define VSF_CONFIG_PREFIX \"\"|#define VSF_CONFIG_PREFIX \"vsftpd.\"|" /wrkdirs/usr/ports/ftp/vsftpd-ext/work/vsFTPd-3.0.2-ext.1/builddefs.h /usr/bin/sed -i.bak -e "s|/etc/v|/usr/local/etc/v|" /wrkdirs/usr/ports/ftp/vsftpd-ext/work/vsFTPd-3.0.2-ext.1/vsftpd.8 /wrkdirs/usr/ports/ftp/vsftpd-ext/work/vsFTPd-3.0.2-ext.1/vsftpd.conf.5 /usr/bin/sed -i.bak -e "s|/usr/share/empty|/usr/local/share/vsftpd/empty|" /wrkdirs/usr/ports/ftp/vsftpd-ext/work/vsFTPd-3.0.2-ext.1/tunables.c /usr/bin/sed -i.bak -e "s|-O2 ||" -e '/^CC/s/=/?=/' -e '/^CFLAGS/{s/=/+=/;s/-O[0-9]//;}' -e '/^LIBS/s|=.*|= `./vsf_findlibs.sh`|' -e '/^LINK/s/=.*/=/' -e 's|-Werror||' /wrkdirs/usr/ports/ftp/vsftpd-ext/work/vsFTPd-3.0.2-ext.1/Makefile /usr/bin/sed -i.bak -e '/-lutil/d' /wrkdirs/usr/ports/ftp/vsftpd-ext/work/vsFTPd-3.0.2-ext.1/vsf_findlibs.sh /usr/bin/sed -i.bak -e "s|^listen=.*|listen=NO|" /wrkdirs/usr/ports/ftp/vsftpd-ext/work/vsFTPd-3.0.2-ext.1/vsftpd.conf =========================================================================== =======================<phase: build >============================ ===> Building for vsftpd-ext-3.0.2.1_2 cc -c sysdeputil.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc sysdeputil.c: In function 'vsf_sysdep_check_auth': sysdeputil.c:334: warning: unused variable 'pam_user_name' sysdeputil.c:333: warning: unused variable 'item' cc -c http.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c secutil.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c access.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c oneprocess.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c features.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c ls.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c charconv.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c pasvrules.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c secbuf.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c prelogin.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c ftpcmdio.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c tunables.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c sysstr.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c ftpdataio.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c ssl.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c ptracesandbox.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c ascii.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c logging.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c filestr.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c netstr.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c strlist.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c twoprocess.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c sysutil.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc sysutil.c: In function 'vsf_sysutil_get_datetimefmt': sysutil.c:2828: warning: passing argument 1 of 'gmtime' from incompatible pointer type sysutil.c:2830: warning: passing argument 1 of 'localtime' from incompatible pointer type cc -c sslslave.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c hash.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c main.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c utility.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c seccompsandbox.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c usersip.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c ftppolicy.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c postlogin.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c ipaddrparse.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c parseconf.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c str.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c readwrite.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c opts.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c postprivparent.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c banner.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c tcpwrap.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c http_msg.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c standalone.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c privops.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c privsock.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -c http_str.c -O2 -pipe -fno-strict-aliasing -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wall -W -Wshadow -Wformat-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc cc -o vsftpd -fPIE -pie -Wl,-z,relro -Wl,-z,now http.o privops.o sysstr.o charconv.o oneprocess.o ftppolicy.o secbuf.o ptracesandbox.o ascii.o netstr.o twoprocess.o sysutil.o sslslave.o hash.o main.o seccompsandbox.o ipaddrparse.o parseconf.o str.o opts.o privsock.o sysdeputil.o postprivparent.o secutil.o features.o access.o http_msg.o ls.o pasvrules.o prelogin.o ftpcmdio.o tunables.o ftpdataio.o ssl.o filestr.o strlist.o utility.o usersip.o readwrite.o logging.o tcpwrap.o banner.o standalone.o postlogin.o http_str.o `./vsf_findlibs.sh` sysutil.o: In function `vsf_sysutil_tzset': sysutil.c:(.text+0x13da): undefined reference to `__stack_chk_fail_local' sysutil.o: In function `vsf_sysutil_parse_time': sysutil.c:(.text+0x306a): undefined reference to `__stack_chk_fail_local' sysutil.o: In function `vsf_sysutil_sockaddr_in_mask': sysutil.c:(.text+0x3ac8): undefined reference to `__stack_chk_fail_local' sysutil.o: In function `vsf_sysutil_getpeername': sysutil.c:(.text+0x3c75): undefined reference to `__stack_chk_fail_local' sysutil.o: In function `vsf_sysutil_getsockname': sysutil.c:(.text+0x3d45): undefined reference to `__stack_chk_fail_local' sysutil.o:sysutil.c:(.text+0x44d2): more undefined references to `__stack_chk_fail_local' follow Makefile:34: recipe for target 'vsftpd' failed gmake: *** [vsftpd] Error 1 *** [do-build] Error code 1 Stop in /usr/ports/ftp/vsftpd-ext.
Created attachment 159243 [details] vsftp_buildfix_revised.patch Xu, I've attached a revised patch the does a slight rework of your original suggestion that allows using /usr/bin/clang if it exists. I've also gone ahead and fixed several other portlint issues. Summary: - Force clang on FreeBSD < 10.0 to resolve 9.x i386 build issues - Modernize USES with tar:tgz - Rely on USERS/GROUPS; remove pkg-install/pkg deinstall scripts - Remove direct chmod usage - Regen patch to pet portlint PR: 200791 Submitted by: Xu Jing (maintainer - original patch) MFH: 2015Q3 Details: - Force clang on FreeBSD < 10.0 to resolve 9.x i386 build issues I made one small change to the maintainer's submission in that /usr/bin/clang is used if it exists. Otherwise as originally written lang/clang33 will be used. This also resolves these two portlint issues: FATAL: Makefile: extra item "BROKEN_FreeBSD_9_i386" placed in the LICENSE section. WARN: Makefile: "LICENSE" has to appear earlier. - Modernize USES with tar:tgz Resolves the following portlint issue: WARN: Makefile: EXTRACT_SUFX is ".tgz". Please use USES=tar:tgz instead. - Rely on USERS/GROUPS; remove pkg-install/pkg deinstall scripts Justification is self explanatory. ftp/vsftpd removed the standalone scripts some time ago and pkg can be seen doing this on install. ===> Creating users and/or groups. Using existing group 'ftp'. Using existing user 'ftp'. This also indirectly resolves the following portlint issue: WARN: /usr/ports/ftp/vsftpd-ext/pkg-install: possible use of absolute pathname "/var/ftp". - Remove direct chmod usage I'll attach a supplemental log that permissions of all the /usr/local/share files are 644 no matter what. If needed the pkg-plist version can be used instead but there is no justification to do so as the default is covering it. Resolves this portlint: WARN: Makefile: [118]: possible use of "${CHMOD}" found. Use @(owner,group,mode) syntax or @owner/@group operators in pkg-plist instead. - Regen patch to pet portlint Resolves this: WARN: /usr/ports/ftp/vsftpd-ext/files/patch-utility: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' to ensure proper patch format. Other Issues: I did not address this on the grounds that it has been a long existing port and I'm not sure the best way to ensure this doesn't break anything. WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX. I did not address this as the port is building as intended with and without the options along with ftp/vsftpd is still using the same code at this time. WARN: Makefile: you should only use ".if ${PORT_OPTIONS:MDOCS}" to wrap installation of files into /usr/local/share/doc if the collection of files is large and it takes considerable time to copy.
Created attachment 159244 [details] 9.3 i386 Poudriere build log -- DOCS (In reply to Jason Unovitch from comment #1) Supporting my above comment, this is with DOCS=on DOCS=on: Build and/or install documentation RC_SCRIPT=on: install RC_SCRIPT VSFTPD_SSL=off: Include support for SSL
Created attachment 159245 [details] 9.3 i386 Poudriere build log -- NODOCS (In reply to Jason Unovitch from comment #1) Supporting my above comment, this is with DOCS=off DOCS=off: Build and/or install documentation RC_SCRIPT=on: install RC_SCRIPT VSFTPD_SSL=off: Include support for SSL
Created attachment 159246 [details] sdiff of permissions to support "- Remove direct chmod usage" (In reply to Jason Unovitch from comment #1) Attached sdiff of permissions of files installed by vsftpd-ext to show that all the doc files are 644 both with and without the CHMOD
Dmitry, I'm CC'ing you for comments based on r390928 and r390559 to mark ftp/vsftpd-ext BROKEN on 9.3 when this PR already included the maintainer's fix. I've reworked the maintainer's submission to address extra issues identified by portlint.
Last comment: I attached the 9.3 i386 log to show that the issue was resolved however I also build tested successfully on the following jails in Poudriere: 8.4-RELEASE-p31 amd64 8.4-RELEASE-p31 i386 9.3-RELEASE-p17 amd64 9.3-RELEASE-p17 i386 10.1-RELEASE-p14 amd64 10.1-RELEASE-p14 i386 10.2-BETA2 amd64 10.2-BETA2 i386 11.0-CURRENT r284725 amd64 11.0-CURRENT r284725 i386
LGTM; though why do you check for ${STAGEDIR}/usr/bin/clang? This check will always be false. I guess you've meant just /usr/bin/clang there.
Thanks Dmitry, I submitted this before getting commit access. Let me review the patch closer when I get back to a computer and I will go through my mentors for review.
Ok, feel free to take the pr.
Created attachment 159860 [details] vsftp_buildfix_revised.patch ftp/vsftpd-ext: unbreak 9.x i386 build issue and clean up port - Force clang on FreeBSD < 10.0 to resolve 9.x i386 build issues - Modernize USES with tar:tgz - Rely on USERS/GROUPS; remove pkg-install/pkg deinstall scripts - Remove direct chmod usage - Regen patch to pet portlint PR: 200791 Submitted by: Xu Jing (maintainer - original patch) Approved by: feld|delphij|pgollucci (mentor) MFH: 2015Q3
(In reply to Dmitry Marakasov from comment #9) Thanks for the feed back Dmitry. Good catch on my error. I got this.
A commit references this bug: Author: junovitch Date: Fri Aug 14 16:57:56 UTC 2015 New revision: 394236 URL: https://svnweb.freebsd.org/changeset/ports/394236 Log: ftp/vsftpd-ext: unbreak build on 9.x i386 and clean up port - Force clang on FreeBSD < 10.0 to resolve 9.x i386 build issues - Modernize USES with tar:tgz - Rely on USERS/GROUPS; remove pkg-install/pkg deinstall scripts - Remove direct chmod usage - Regen patch to pet portlint PR: 200791 Submitted by: Xu Jing <xjflyttp@gmail.com> (maintainer - original version) Approved by: delphij (mentor) MFH: 2015Q3 Changes: head/ftp/vsftpd-ext/Makefile head/ftp/vsftpd-ext/files/patch-utility head/ftp/vsftpd-ext/pkg-deinstall head/ftp/vsftpd-ext/pkg-install
A commit references this bug: Author: junovitch Date: Fri Aug 14 17:06:49 UTC 2015 New revision: 394239 URL: https://svnweb.freebsd.org/changeset/ports/394239 Log: MFH: r394236 ftp/vsftpd-ext: unbreak build on 9.x i386 and clean up port - Force clang on FreeBSD < 10.0 to resolve 9.x i386 build issues - Modernize USES with tar:tgz - Rely on USERS/GROUPS; remove pkg-install/pkg deinstall scripts - Remove direct chmod usage - Regen patch to pet portlint PR: 200791 Submitted by: Xu Jing <xjflyttp@gmail.com> (maintainer - original version) Approved by: ports-secteam (feld), delphij (mentor) Changes: _U branches/2015Q3/ branches/2015Q3/ftp/vsftpd-ext/Makefile branches/2015Q3/ftp/vsftpd-ext/files/patch-utility branches/2015Q3/ftp/vsftpd-ext/pkg-deinstall branches/2015Q3/ftp/vsftpd-ext/pkg-install
Xu, Committed with extra fixes. Thank you for your submission!