Bug 200819 - [maintainer update] for graphics/openshadinglanguage
Summary: [maintainer update] for graphics/openshadinglanguage
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Marcus von Appen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-12 14:19 UTC by Shane
Modified: 2015-07-08 17:02 UTC (History)
1 user (show)

See Also:

Attachments
update openshadinglanguage to 1.6.6 (17.02 KB, patch)
2015-06-12 14:19 UTC, Shane 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shane 2015-06-12 14:19:50 UTC 
Created attachment 157678 [details]
update openshadinglanguage to 1.6.6

Update graphics/openshadinglanguage to v1.6.6

This does not compile with openimageio v1.4.x the openimageio 1.5.16 update needs to be applied before this, see - bug #200818

Only 2 patches remain which have been updated to quite portlint in regards to make makepatch created patches.
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2015-06-20 07:24:40 UTC 
This suffers from the same issue as openimageio (bug 200818 comment 5).
Comment 2 Shane 2015-06-22 07:23:13 UTC 
I don't see anywhere there is specific use of simd in osl.

In src/liboslexec/CMakeLists.txt any USE_SIMD option is added to LLVM_COMPILE_FLAGS, I'm not certain if this means the flags will be used to compile the compiler or will be passed on to be used by the compiler when compiling the osl code.
Comment 3 Marcus von Appen freebsd_committer freebsd_triage 2015-06-22 09:56:36 UTC 
I think this relates to the intertwining of both and the fact that OpenImageIO makes internals partially visible to external callers (through the simd.h header).

Within CMakeLists.txt, osl sets -DOIIO_NO_SSE=1 on demand, which is relevant for e.g. src/liboslexec/noiseimpl.h.

It really gives me the creeps to look at things like that, since this in turn means that OpenImageIO AND OpenShadingLanguage are likely to break, if not compiled with the same SIMD instructions (or one is updsated with different flags later on).
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-07-08 16:52:32 UTC 
A commit references this bug:

Author: mva
Date: Wed Jul  8 16:52:02 UTC 2015
New revision: 391573
URL: https://svnweb.freebsd.org/changeset/ports/391573

Log:
  - Update to version 1.6.6

  OpenShadingLanguage 1.6 comes with new features and lots of bug fixes:
  * new OSL operators and arrays of undefined length can be passed to the
    shaders now
  * many API enhancements for the render services and shader contexts

  Changelog: https://github.com/imageworks/OpenShadingLanguage/blob/RB-1.6/CHANGES

  PR:		200819
  Submitted by:	Shane Ambler <FreeBSD@ShaneWare.Biz>

Changes:
  head/graphics/openshadinglanguage/Makefile
  head/graphics/openshadinglanguage/distinfo
  head/graphics/openshadinglanguage/files/patch-CMakeLists.txt
  head/graphics/openshadinglanguage/files/patch-alignment.patch
  head/graphics/openshadinglanguage/files/patch-doc__CMakeLists.txt
  head/graphics/openshadinglanguage/files/patch-shaders__CMakeLists.txt
  head/graphics/openshadinglanguage/files/patch-src_doc_CMakeLists.txt
  head/graphics/openshadinglanguage/files/patch-src_shaders_CMakeLists.txt
  head/graphics/openshadinglanguage/pkg-plist
Comment 5 Marcus von Appen freebsd_committer freebsd_triage 2015-07-08 17:02:16 UTC 
Committed, thanks!