Bug 200824 - [MAINTAINER] x11/libfm: convert to master-slave; add missing header
Summary: [MAINTAINER] x11/libfm: convert to master-slave; add missing header
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: patch, patch-ready
Depends on: 200825
Blocks:
  Show dependency tree / graph
 
Reported: 2015-06-12 19:22 UTC by Horia Racoviceanu
Modified: 2015-08-01 10:18 UTC (History)
2 users (show)

See Also:

Attachments
libfm.diff (7.82 KB, patch)
2015-06-12 19:22 UTC, Horia Racoviceanu 		no flags Details | Diff
libfm.diff (7.91 KB, patch)
2015-06-15 22:53 UTC, Horia Racoviceanu 		no flags Details | Diff
Build log: libfm-1.2.3_1-10amd64.log (74.63 KB, text/plain)
2015-06-15 22:54 UTC, Horia Racoviceanu 		no flags Details
Build log: menu-cache-1.0.0-10amd64.log (25.35 KB, text/plain)
2015-06-15 22:55 UTC, Horia Racoviceanu 		no flags Details
Build log: libfm-extra-1.2.3_1-10amd64.log (26.75 KB, text/plain)
2015-06-15 22:56 UTC, Horia Racoviceanu 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Horia Racoviceanu 2015-06-12 19:22:45 UTC 
Created attachment 157686 [details]
libfm.diff

- Convert x11/libfm and x11/libfm-extra to Master-Slave Port
  (same application, CATEGORIES, DISTFILES, install path)
- Bump PORTREVISION
- Add missing fm-actions header
- Move patches to Makefile
Comment 1 Horia Racoviceanu 2015-06-12 19:27:37 UTC 
Linked with Bug 200825
Comment 2 Olivier Duchateau freebsd_committer freebsd_triage 2015-06-15 16:27:27 UTC 
(In reply to Horia Racoviceanu from comment #0)

I think it's wrong. There's circular dependencies.

x11/libfm-extra (and only this library) is required by x11/menu-cache >= 1.0.0 and menu-cache is needed by x11/libfm in order to build this port. I think split is a best thing.

Furthemore, patch-configure is needed if someone doesn't build NLS support, if you remove this patch, traductions are always installed.
Comment 3 Horia Racoviceanu 2015-06-15 22:53:08 UTC 
Created attachment 157776 [details]
libfm.diff

- Convert x11/libfm and x11/libfm-extra to Master-Slave Port
  (same application, CATEGORIES, DISTFILES, install path)
- Bump PORTREVISION
- Add missing fm-actions header
- Move patches to Makefile

* Add missing NLS patch-configure
  NLS related files were built and installed in STAGEDIR when the NLS option
  was disabled, but OPTIONS_SUB=yes prevented them to `make install` on host.

# portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
0 fatal errors and 3 warnings found.
Comment 4 Horia Racoviceanu 2015-06-15 22:54:58 UTC 
Created attachment 157777 [details]
Build log: libfm-1.2.3_1-10amd64.log
Comment 5 Horia Racoviceanu 2015-06-15 22:55:48 UTC 
Created attachment 157778 [details]
Build log: menu-cache-1.0.0-10amd64.log
Comment 6 Horia Racoviceanu 2015-06-15 22:56:18 UTC 
Created attachment 157779 [details]
Build log: libfm-extra-1.2.3_1-10amd64.log
Comment 7 Horia Racoviceanu 2015-06-15 23:15:21 UTC 
(In reply to Olivier Duchateau from comment #2)

Dependencies are not affected by this patch and Bug 200825. They remain the same: build logs testing Bug 200824 and Bug 200825 simultaneously. It only converts to master-slave.

Your NLS patch-configure is needed and I included it in attachment 157776 [details]
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-08-01 10:16:38 UTC 
A commit references this bug:

Author: riggs
Date: Sat Aug  1 10:15:52 UTC 2015
New revision: 393393
URL: https://svnweb.freebsd.org/changeset/ports/393393

Log:
  - Convert x11/libfm and x11/libfm-extra to Master-Slave Port
    (same application, CATEGORIES, DISTFILES, install path)
  - Bump PORTREVISION
  - Add missing fm-actions header
  - Move patches to Makefile

  PR:		200824
  Submitted by:	horia@racoviceanu.com (maintainer)

Changes:
  head/x11/libfm/Makefile
  head/x11/libfm/files/
  head/x11/libfm/pkg-plist