Bug 200865 - [MAINTAINER] net-im/qTox: Update to 0.150614 with dependencies net-im/tox and audio/libfilteraudio
Summary: [MAINTAINER] net-im/qTox: Update to 0.150614 with dependencies net-im/tox and...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-06-15 03:44 UTC by Yuri Victorovich
Modified: 2015-06-18 20:16 UTC (History)
4 users (show)

See Also:


Attachments
patch for qTox (5.40 KB, patch)
2015-06-15 03:44 UTC, Yuri Victorovich
no flags Details | Diff
patch for toxcore (1.35 KB, patch)
2015-06-15 03:44 UTC, Yuri Victorovich
no flags Details | Diff
patch for libfilteraudio (1.14 KB, patch)
2015-06-15 03:45 UTC, Yuri Victorovich
no flags Details | Diff
poudriere log (446.56 KB, text/plain)
2015-06-15 03:53 UTC, Yuri Victorovich
no flags Details
patch for qTox (5.43 KB, patch)
2015-06-15 03:54 UTC, Yuri Victorovich
no flags Details | Diff
patch for qTox (5.40 KB, patch)
2015-06-15 04:57 UTC, Yuri Victorovich
no flags Details | Diff
patch for toxic (1.03 KB, patch)
2015-06-15 20:12 UTC, Thierry Thomas
thierry: maintainer-approval+
Details | Diff
Suggested uTox patch (1.95 KB, patch)
2015-06-16 04:16 UTC, Yuri Victorovich
no flags Details | Diff
patch-uTox.me.variant (2.07 KB, text/plain)
2015-06-18 13:38 UTC, Ivan Klymenko
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2015-06-15 03:44:13 UTC
Created attachment 157745 [details]
patch for qTox
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2015-06-15 03:44:36 UTC
Created attachment 157746 [details]
patch for toxcore
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2015-06-15 03:45:06 UTC
Created attachment 157747 [details]
patch for libfilteraudio
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2015-06-15 03:47:23 UTC
Please note that toxcore had redundant dependencies multimedia/libv4l and multimedia/ffmpeg - I removed them.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2015-06-15 03:53:52 UTC
Created attachment 157748 [details]
poudriere log
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2015-06-15 03:54:26 UTC
Created attachment 157749 [details]
patch for qTox
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2015-06-15 04:57:19 UTC
Created attachment 157754 [details]
patch for qTox
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2015-06-15 06:07:51 UTC
Hi Yuri, can you please:

 * Create a separate issue for net-im/tox (with QA attachments) so that the maintainer can be assigned to resolve it independently
 * Once created, have this issue "depend on" the newly created issue (Use the "Depends on" field)
 * Obsolete attachments in this issue that relate to net-im/tox
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2015-06-15 06:38:28 UTC
Hi Kubilay,

These ports are closely related, and should be updated together and frequently (because they are also developed rapidly).

Usually thierry@ was committing them together.

Yuri
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2015-06-15 06:49:54 UTC
I understand that they may need to be committed together, but that does not in itself preclude creating separate issues for the changes. 

The be clear, the main reasons for needing this is to:

 * Clearly establish the responsibility for each change, given that Thierry is the maintainer for one (and only one) of the changes being requested.
 * Ensure that if the maintainer cannot respond or resolve the dependency changes needed in a timely manner, that someone else may resolve it.

As it stands now with all of the changes in a single issue, and with multiple persons responsible for action, there is nothing that can be used (ie; a maintainer timeout) to compel a change without approval.
Comment 10 Thierry Thomas freebsd_committer freebsd_triage 2015-06-15 20:11:19 UTC
There is a problem with the submitted patches: as usual, the API changed, and now uTox (and toxic) are broken.

Not a real problem for toxic, and I add a patch to upgrade it.

For uTox, the messages are:

  CC    friend.o
tox.c:546:48: error: too many arguments to function call, expected 2, have 4
        if((tox = tox_new(&options, save_data, save_size, &tox_new_err)) == NULL) {
                  ~~~~~~~                      ^~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/tox/tox.h:615:1: note: 'tox_new' declared here
Tox *tox_new(const struct Tox_Options *options, TOX_ERR_NEW *error);
^
tox.c:548:118: error: too many arguments to function call, expected 2, have 4
            if(!options.proxy_type || (options.proxy_type = TOX_PROXY_TYPE_NONE, (tox = tox_new(&options, save_data, save_size, &tox_new_err)) == NULL)) {
                                                                                        ~~~~~~~                      ^~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/tox/tox.h:615:1: note: 'tox_new' declared here
Tox *tox_new(const struct Tox_Options *options, TOX_ERR_NEW *error);
^
tox.c:550:108: error: too many arguments to function call, expected 2, have 4
                if(!options.ipv6_enabled || (options.ipv6_enabled = 0, (tox = tox_new(&options, save_data, save_size, &tox_new_err)) == NULL)) {
                                                                              ~~~~~~~                      ^~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/tox/tox.h:615:1: note: 'tox_new' declared here
Tox *tox_new(const struct Tox_Options *options, TOX_ERR_NEW *error);

Ivan, could you please check if refreshing uTox is sufficient?
Comment 11 Thierry Thomas freebsd_committer freebsd_triage 2015-06-15 20:12:42 UTC
Created attachment 157767 [details]
patch for toxic

Patch to upgrade net-im/toxic and chase the new toxcore.
Comment 12 Thierry Thomas freebsd_committer freebsd_triage 2015-06-15 20:14:31 UTC
(In reply to Kubilay Kocak from comment #9)

koobs, I approve the submitted patch for my port, and I have taken this PR.
Comment 13 Yuri Victorovich freebsd_committer freebsd_triage 2015-06-15 21:46:59 UTC
Thierry,

uTox builds for me with upstream rev.5a5132f.
Comment 14 Yuri Victorovich freebsd_committer freebsd_triage 2015-06-16 04:16:16 UTC
Created attachment 157793 [details]
Suggested uTox patch

uTox patch that works for me.
Comment 15 Thierry Thomas freebsd_committer freebsd_triage 2015-06-16 19:31:32 UTC
(In reply to yuri from comment #14)
Thanks! Waiting for fidaj's approval.
Comment 16 Ivan Klymenko 2015-06-18 13:38:06 UTC
Created attachment 157860 [details]
patch-uTox.me.variant


Some minor fixes.
Comment 17 Ivan Klymenko 2015-06-18 13:40:01 UTC
At first glance, no problems found.
Comment 18 commit-hook freebsd_committer freebsd_triage 2015-06-18 19:51:27 UTC
A commit references this bug:

Author: thierry
Date: Thu Jun 18 19:50:58 UTC 2015
New revision: 390058
URL: https://svnweb.freebsd.org/changeset/ports/390058

Log:
  Upgrade Tox, libfilteraudio, toxic, qTox and uTox to a recent snapshot.

  PR:		ports/200865
  Submitted by:	yuri (at) rawbw.com (qTox maintainer) + patches from other maintainers
  Approved by:	maintainers

Changes:
  head/audio/libfilteraudio/Makefile
  head/audio/libfilteraudio/distinfo
  head/net-im/qTox/Makefile
  head/net-im/qTox/distinfo
  head/net-im/qTox/files/patch-qtox.pro
  head/net-im/qTox/files/patch-src_main.cpp
  head/net-im/qTox/files/patch-src_platform_camera_v4l2.cpp
  head/net-im/qTox/files/patch-src_platform_camera_v4l2.h
  head/net-im/tox/Makefile
  head/net-im/tox/distinfo
  head/net-im/toxic/Makefile
  head/net-im/toxic/distinfo
  head/net-im/uTox/Makefile
  head/net-im/uTox/distinfo
  head/net-im/uTox/files/patch-Makefile
Comment 19 Thierry Thomas freebsd_committer freebsd_triage 2015-06-18 19:53:56 UTC
Note to Yuri: since you replaced libtoxcore.a by libtoxcore.so, qTox cannot be built if toxcore depends on NaCl; is this necessary?
Comment 20 Yuri Victorovich freebsd_committer freebsd_triage 2015-06-18 20:16:55 UTC
> Note to Yuri: since you replaced libtoxcore.a by libtoxcore.so, qTox cannot be > built if toxcore depends on NaCl; is this necessary?

Thierry,

Thanks for noting this.
I will review this for the next update, and if necessary will discuss it with you then.

Thanks!
Yuri